Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 721473002: Removed ScrollingCoordinator and a bunch of composited scrolling' (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Removed ScrollingCoordinator and a bunch of composited scrolling R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e02675be14b2e968cb6230ad767b70baed34ccf9

Patch Set 1 #

Patch Set 2 : moar #

Total comments: 1

Patch Set 3 : cr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1025 lines) Patch
M sky/engine/core/core.gni View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
D sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 2 1 chunk +0 lines, -92 lines 0 comments Download
D sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 1 chunk +0 lines, -271 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 6 chunks +2 lines, -50 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.h View 10 chunks +1 line, -32 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 1 33 chunks +5 lines, -356 lines 0 comments Download
M sky/engine/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.h View 4 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 8 chunks +0 lines, -75 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.h View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsLayer.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsLayerClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 4 chunks +2 lines, -30 lines 0 comments Download
M sky/engine/public/platform/WebCompositorSupport.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/public/platform/WebThemeEngine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/LinkHighlight.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ojan
Please remove the BUG= and the random apostrophe from the change description. lgtm once you're ...
6 years, 1 month ago (2014-11-11 23:02:53 UTC) #3
rafaelw
done & smoke-tested that scrollbars still draw & wheel-based scrolling works
6 years, 1 month ago (2014-11-12 00:42:02 UTC) #4
rafaelw
6 years, 1 month ago (2014-11-12 00:42:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e02675be14b2e968cb6230ad767b70baed34ccf9.

Powered by Google App Engine
This is Rietveld 408576698