Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: sky/engine/core/page/Page.h

Issue 721473002: Removed ScrollingCoordinator and a bunch of composited scrolling' (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/loader/FrameLoader.cpp ('k') | sky/engine/core/page/Page.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 class FocusController; 48 class FocusController;
49 class Frame; 49 class Frame;
50 class FrameHost; 50 class FrameHost;
51 class PageLifecycleNotifier; 51 class PageLifecycleNotifier;
52 class PlatformMouseEvent; 52 class PlatformMouseEvent;
53 class Range; 53 class Range;
54 class RenderBox; 54 class RenderBox;
55 class RenderObject; 55 class RenderObject;
56 class VisibleSelection; 56 class VisibleSelection;
57 class ScrollableArea; 57 class ScrollableArea;
58 class ScrollingCoordinator;
59 class ServiceProvider; 58 class ServiceProvider;
60 class Settings; 59 class Settings;
61 class SpellCheckerClient; 60 class SpellCheckerClient;
62 class UndoStack; 61 class UndoStack;
63 62
64 typedef uint64_t LinkHash; 63 typedef uint64_t LinkHash;
65 64
66 float deviceScaleFactor(LocalFrame*); 65 float deviceScaleFactor(LocalFrame*);
67 66
68 class Page final : public Supplementable<Page>, public LifecycleContext<Page>, p ublic SettingsDelegate { 67 class Page final : public Supplementable<Page>, public LifecycleContext<Page>, p ublic SettingsDelegate {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 109
111 bool openedByDOM() const; 110 bool openedByDOM() const;
112 void setOpenedByDOM(); 111 void setOpenedByDOM();
113 112
114 PageAnimator& animator() { return m_animator; } 113 PageAnimator& animator() { return m_animator; }
115 Chrome& chrome() const { return *m_chrome; } 114 Chrome& chrome() const { return *m_chrome; }
116 AutoscrollController& autoscrollController() const { return *m_autoscrollCon troller; } 115 AutoscrollController& autoscrollController() const { return *m_autoscrollCon troller; }
117 DragCaretController& dragCaretController() const { return *m_dragCaretContro ller; } 116 DragCaretController& dragCaretController() const { return *m_dragCaretContro ller; }
118 FocusController& focusController() const { return *m_focusController; } 117 FocusController& focusController() const { return *m_focusController; }
119 118
120 ScrollingCoordinator* scrollingCoordinator();
121
122 Settings& settings() const { return *m_settings; } 119 Settings& settings() const { return *m_settings; }
123 120
124 UseCounter& useCounter() { return m_useCounter; } 121 UseCounter& useCounter() { return m_useCounter; }
125 122
126 void setTabKeyCyclesThroughElements(bool b) { m_tabKeyCyclesThroughElements = b; } 123 void setTabKeyCyclesThroughElements(bool b) { m_tabKeyCyclesThroughElements = b; }
127 bool tabKeyCyclesThroughElements() const { return m_tabKeyCyclesThroughEleme nts; } 124 bool tabKeyCyclesThroughElements() const { return m_tabKeyCyclesThroughEleme nts; }
128 125
129 void unmarkAllTextMatches(); 126 void unmarkAllTextMatches();
130 127
131 float deviceScaleFactor() const { return m_deviceScaleFactor; } 128 float deviceScaleFactor() const { return m_deviceScaleFactor; }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 void setNeedsLayoutInAllFrames(); 169 void setNeedsLayoutInAllFrames();
173 170
174 // SettingsDelegate overrides. 171 // SettingsDelegate overrides.
175 virtual void settingsChanged(SettingsDelegate::ChangeType) override; 172 virtual void settingsChanged(SettingsDelegate::ChangeType) override;
176 173
177 PageAnimator m_animator; 174 PageAnimator m_animator;
178 const OwnPtr<AutoscrollController> m_autoscrollController; 175 const OwnPtr<AutoscrollController> m_autoscrollController;
179 const OwnPtr<Chrome> m_chrome; 176 const OwnPtr<Chrome> m_chrome;
180 const OwnPtr<DragCaretController> m_dragCaretController; 177 const OwnPtr<DragCaretController> m_dragCaretController;
181 const OwnPtr<FocusController> m_focusController; 178 const OwnPtr<FocusController> m_focusController;
182 OwnPtr<ScrollingCoordinator> m_scrollingCoordinator;
183 const OwnPtr<UndoStack> m_undoStack; 179 const OwnPtr<UndoStack> m_undoStack;
184 180
185 // Typically, the main frame and Page should both be owned by the embedder, 181 // Typically, the main frame and Page should both be owned by the embedder,
186 // which must call Page::willBeDestroyed() prior to destroying Page. This 182 // which must call Page::willBeDestroyed() prior to destroying Page. This
187 // call detaches the main frame and clears this pointer, thus ensuring that 183 // call detaches the main frame and clears this pointer, thus ensuring that
188 // this field only references a live main frame. 184 // this field only references a live main frame.
189 // 185 //
190 // However, there are several locations (InspectorOverlay) 186 // However, there are several locations (InspectorOverlay)
191 // which don't hold a reference to the main frame at all 187 // which don't hold a reference to the main frame at all
192 // after creating it. These are still safe because they always create a 188 // after creating it. These are still safe because they always create a
(...skipping 27 matching lines...) Expand all
220 HashSet<RawPtr<MultisamplingChangedObserver> > m_multisamplingChangedObserve rs; 216 HashSet<RawPtr<MultisamplingChangedObserver> > m_multisamplingChangedObserve rs;
221 217
222 // A pointer to all the interfaces provided to in-process Frames for this Pa ge. 218 // A pointer to all the interfaces provided to in-process Frames for this Pa ge.
223 // FIXME: Most of the members of Page should move onto FrameHost. 219 // FIXME: Most of the members of Page should move onto FrameHost.
224 OwnPtr<FrameHost> m_frameHost; 220 OwnPtr<FrameHost> m_frameHost;
225 }; 221 };
226 222
227 } // namespace blink 223 } // namespace blink
228 224
229 #endif // Page_h 225 #endif // Page_h
OLDNEW
« no previous file with comments | « sky/engine/core/loader/FrameLoader.cpp ('k') | sky/engine/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698