Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 721383003: bindings: Retires ScriptWrappableBase mostly. (Closed)

Created:
6 years, 1 month ago by Yuki
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Project:
blink
Visibility:
Public.

Description

bindings: Retires ScriptWrappableBase mostly. Removes functions which take ScriptWrappableBase as an argument in DOMDataStore, V8Wrapper, and V8Binding. ScriptWrappableBase is still used as the internal pointer in a wrapper, and it's used to support NPObject. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185370

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -429 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/DOMDataStore.h View 9 chunks +16 lines, -68 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.h View 1 4 chunks +10 lines, -18 lines 2 comments Download
M Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 4 chunks +0 lines, -37 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_overall.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/bindings/tests/idls/core/TestInterfaceNotScriptWrappable.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp View 1 chunk +0 lines, -143 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuki
Could you review this CL?
6 years, 1 month ago (2014-11-14 08:06:34 UTC) #2
haraken
LGTM https://codereview.chromium.org/721383003/diff/20001/Source/bindings/core/v8/ScriptWrappable.h File Source/bindings/core/v8/ScriptWrappable.h (right): https://codereview.chromium.org/721383003/diff/20001/Source/bindings/core/v8/ScriptWrappable.h#newcode51 Source/bindings/core/v8/ScriptWrappable.h:51: #if COMPILER(MSVC) Can we remove this comment now, ...
6 years, 1 month ago (2014-11-14 08:21:20 UTC) #3
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-14 08:42:22 UTC) #5
Yuki
https://codereview.chromium.org/721383003/diff/20001/Source/bindings/core/v8/ScriptWrappable.h File Source/bindings/core/v8/ScriptWrappable.h (right): https://codereview.chromium.org/721383003/diff/20001/Source/bindings/core/v8/ScriptWrappable.h#newcode51 Source/bindings/core/v8/ScriptWrappable.h:51: #if COMPILER(MSVC) On 2014/11/14 08:21:20, haraken wrote: > > ...
6 years, 1 month ago (2014-11-14 11:25:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721383003/20001
6 years, 1 month ago (2014-11-14 11:25:57 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 13:00:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185370

Powered by Google App Engine
This is Rietveld 408576698