Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: Source/bindings/core/v8/ScriptWrappable.cpp

Issue 721383003: bindings: Retires ScriptWrappableBase mostly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptWrappable.cpp
diff --git a/Source/bindings/core/v8/ScriptWrappable.cpp b/Source/bindings/core/v8/ScriptWrappable.cpp
index 6db86fc252b5fb5d06bc1a09577ea9769c657223..a58fb9d2198e8226310454f84930db772acbb6cf 100644
--- a/Source/bindings/core/v8/ScriptWrappable.cpp
+++ b/Source/bindings/core/v8/ScriptWrappable.cpp
@@ -46,27 +46,6 @@ private:
} // namespace
-// ScriptWrappableBase
-
-v8::Handle<v8::Object> ScriptWrappableBase::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate, const WrapperTypeInfo* wrapperTypeInfo)
-{
- // It's possible that no one except for the new wrapper owns this object at
- // this moment, so we have to prevent GC to collect this object until the
- // object gets associated with the wrapper.
- ScriptWrappableBaseProtector protect(this, wrapperTypeInfo);
-
- ASSERT(!DOMDataStore::containsWrapper(this, isolate));
-
- v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creationContext, wrapperTypeInfo, this);
- if (UNLIKELY(wrapper.IsEmpty()))
- return wrapper;
-
- wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate);
- return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperTypeInfo, wrapper);
-}
-
-// ScriptWrappable
-
v8::Handle<v8::Object> ScriptWrappable::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();

Powered by Google App Engine
This is Rietveld 408576698