Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: Source/core/paint/LayerPainter.h

Issue 721363002: [New Multicolumn] Make rounded corners clipping multicol-aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase master Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/FilterPainter.cpp ('k') | Source/core/paint/LayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/LayerPainter.h
diff --git a/Source/core/paint/LayerPainter.h b/Source/core/paint/LayerPainter.h
index 484718abfd507f66bcd5a669bff4fbab06ec31d8..4b66f8e9c48c9564049c60f99961da055521d364 100644
--- a/Source/core/paint/LayerPainter.h
+++ b/Source/core/paint/LayerPainter.h
@@ -30,7 +30,15 @@ public:
void paintOverlayScrollbars(GraphicsContext*, const LayoutRect& damageRect, PaintBehavior, RenderObject* paintingRoot = 0);
enum BorderRadiusClippingRule { IncludeSelfForBorderRadius, DoNotIncludeSelfForBorderRadius };
- static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
+
+ // Set rounded clip rectangles defined by border radii all the way from the LayerPaintingInfo
+ // "root" layer down to the specified layer (or the parent of said layer, in case
+ // BorderRadiusClippingRule says to skip self). fragmentOffset is used for multicol, to specify
+ // the translation required to get from flow thread coordinates to visual coordinates for a
+ // certain column.
+ // FIXME: The BorderRadiusClippingRule parameter is really useless now. If we want to skip self,
+ // why not just supply the parent layer as the first parameter instead?
+ static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, const LayoutPoint& fragmentOffset, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
private:
enum ClipState { HasNotClipped, HasClipped };
« no previous file with comments | « Source/core/paint/FilterPainter.cpp ('k') | Source/core/paint/LayerPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698