Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 720783002: Optionally compress V8 code cache data with snappy. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix for the default case Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8ScriptRunnerTest.cpp
diff --git a/Source/bindings/core/v8/V8ScriptRunnerTest.cpp b/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
index 5e9c054a21bdb0399e9af4a3f26f1626d75b1f15..a3ced628239852cf56174b1f5063234bc45525e1 100644
--- a/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
+++ b/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
@@ -138,6 +138,17 @@ TEST_F(V8ScriptRunnerTest, codeOptions)
// FIXME: Code caching is presently still disabled.
// Enable EXPECT when code caching lands.
+ // EXPECT_TRUE(m_resource->cachedMetadata(tagForCodeCache(false)));
+}
+
+TEST_F(V8ScriptRunnerTest, codeCompressedOptions)
+{
+ setResource();
+ EXPECT_TRUE(compileScript(V8CacheOptionsCodeCompressed));
+ EXPECT_FALSE(m_resource->cachedMetadata(tagForParserCache()));
+
+ // FIXME: Code caching is presently still disabled.
+ // Enable EXPECT when code caching lands.
vogelheim 2014/11/12 18:53:52 Would there be any way for the test to verify that
// EXPECT_TRUE(m_resource->cachedMetadata(tagForCodeCache()));
}

Powered by Google App Engine
This is Rietveld 408576698