Source/bindings/core/v8/ScriptStreamer.cpp - Issue 720783002: Optionally compress V8 code cache data with snappy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptStreamer.cpp

Issue 720783002: Optionally compress V8 code cache data with snappy. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix for the default case Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/Source/bindings/core/v8/ScriptStreamer.cpp b/Source/bindings/core/v8/ScriptStreamer.cpp

index 60d2a576de23281577568ebe4ecce76840435bae..4e164925c444a15fb3b6b6ddf9c8c6b267b61718 100644

--- a/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -545,7 +545,8 @@ bool ScriptStreamer::startStreamingInternal(PendingScript& script, Settings* set

// default, we generate the parser cache for streamed scripts, to emulate

// the non-streaming behavior (see V8ScriptRunner::compileScript).

v8::ScriptCompiler::CompileOptions compileOption = v8::ScriptCompiler::kProduceParserCache;

- if (settings->v8CacheOptions() == V8CacheOptionsCode)

+ if (settings->v8CacheOptions() == V8CacheOptionsCode

jochen (gone - plz use gerrit) 2014/11/12 15:04:41 nit. everything in one line. blink has no line len

+ || settings->v8CacheOptions() == V8CacheOptionsCodeCompressed)

compileOption = v8::ScriptCompiler::kProduceCodeCache;

// The Resource might go out of scope if the script is no longer

« no previous file with comments | « no previous file | Source/bindings/core/v8/V8CacheOptions.h » ('j') | Source/bindings/core/v8/V8ScriptRunnerTest.cpp » ('J')