ResourcePtr refactoring

ResourcePtr refactoring

- ResourcePtrBase destructor is non-virtual, so make it protected.
- ResourcePtr<R> should accept ResourcePtr<U> only when U* is convertible to R*.
- Use static_cast instead of reinterpret_cast.
- Delete the unused assignment operator.

BUG=None
R=tyoshino

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185271

[tyoshino (SeeGerritForStatus), 2014-11-12 08:53:57]

lgtm

[yhirano, 2014-11-12 09:14:17]

yhirano@chromium.org changed reviewers:
+ japhet@chromium.org

[yhirano, 2014-11-12 09:14:17]

+japhet@ for OWNER review.

[Nate Chapin, 2014-11-12 17:31:28]

https://codereview.chromium.org/720693002/diff/1/Source/core/fetch/ResourcePtr.h
File Source/core/fetch/ResourcePtr.h (right):

https://codereview.chromium.org/720693002/diff/1/Source/core/fetch/ResourcePt...
Source/core/fetch/ResourcePtr.h:53: ResourcePtrBase& operator=(const
ResourcePtrBase&) = delete;
I'm not familiar with this syntax, I assume it's new C++11 goodness? What does
it mean?

[dcheng, 2014-11-12 18:31:14]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2014-11-12 18:31:15]

https://codereview.chromium.org/720693002/diff/1/Source/core/fetch/ResourcePtr.h
File Source/core/fetch/ResourcePtr.h (right):

https://codereview.chromium.org/720693002/diff/1/Source/core/fetch/ResourcePt...
Source/core/fetch/ResourcePtr.h:53: ResourcePtrBase& operator=(const
ResourcePtrBase&) = delete;
On 2014/11/12 17:31:28, Nate Chapin wrote:
> I'm not familiar with this syntax, I assume it's new C++11 goodness? What does
> it mean?

It's an error to call a deleted function, so this disallows code from assigning
ResourcePtrBase. http://msdn.microsoft.com/en-us/library/dn457344.aspx documents
why you might want to delete (or default) certain functions that can be
automatically generated by the compiler.

[Nate Chapin, 2014-11-12 18:41:43]

Thanks. LGTM

[yhirano, 2014-11-13 01:04:15]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-11-13 01:04:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720693002/1

[commit-bot: I haz the power, 2014-11-13 03:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 03:20:14]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36204)

[yhirano1, 2014-11-13 03:22:06]

The CQ bit was checked by yhirano@google.com

[commit-bot: I haz the power, 2014-11-13 03:22:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720693002/1

[yhirano, 2014-11-13 03:29:01]

yhirano@chromium.org changed reviewers:
- yhirano@google.com

[yhirano, 2014-11-13 05:31:20]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-11-13 05:32:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720693002/60001

[commit-bot: I haz the power, 2014-11-13 06:36:16]

Committed patchset #4 (id:60001) as 185271