ResourcePtr refactoring

Source/core/fetch/ResourcePtr.h

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 14 matching lines @@
 
 #ifndef ResourcePtr_h
 #define ResourcePtr_h
 
 #include "core/fetch/Resource.h"
 
 namespace blink {
 
 class ResourcePtrBase {
 public:
-    ~ResourcePtrBase();
-
     Resource* get() const { return m_resource; }
     bool operator!() const { return !m_resource; }
-    void clear() { setResource(0); }
+    void clear() { setResource(nullptr); }
 
     // This conversion operator allows implicit conversion to bool but not to other integer types.
     typedef Resource* ResourcePtrBase::*UnspecifiedBoolType;
-    operator UnspecifiedBoolType() const { return m_resource ? &ResourcePtrBase::m_resource : 0; }
+    operator UnspecifiedBoolType() const { return m_resource ? &ResourcePtrBase::m_resource : nullptr; }
 
 protected:
-    ResourcePtrBase() : m_resource(0) { }
-    ResourcePtrBase(Resource*);
-    ResourcePtrBase(const ResourcePtrBase&);
+    ResourcePtrBase() : m_resource(nullptr) { }
+    explicit ResourcePtrBase(Resource*);
+    explicit ResourcePtrBase(const ResourcePtrBase&);
+    ~ResourcePtrBase();
 
     void setResource(Resource*);
 
 private:
-    ResourcePtrBase& operator=(const ResourcePtrBase&) { return *this; }
-
     friend class Resource;
+    ResourcePtrBase& operator=(const ResourcePtrBase&) = delete;

[Nate Chapin, 2014/11/12 17:31:28]

I'm not familiar with this syntax, I assume it's new C++11 goodness? What does
it mean?

[dcheng, 2014/11/12 18:31:15]

It's an error to call a deleted function, so this disallows code from assigning
ResourcePtrBase. http://msdn.microsoft.com/en-us/library/dn457344.aspx documents
why you might want to delete (or default) certain functions that can be
automatically generated by the compiler.

 
     Resource* m_resource;
 };
 
 inline ResourcePtrBase::ResourcePtrBase(Resource* res)
     : m_resource(res)
 {
     if (m_resource)
         m_resource->registerHandle(this);
 }
 
 inline ResourcePtrBase::~ResourcePtrBase()
 {
     if (m_resource)
         m_resource->unregisterHandle(this);
 }
 
 inline ResourcePtrBase::ResourcePtrBase(const ResourcePtrBase& o)
     : m_resource(o.m_resource)
 {
     if (m_resource)
         m_resource->registerHandle(this);
 }
 
-template <class R> class ResourcePtr : public ResourcePtrBase {
+template <class R> class ResourcePtr final : public ResourcePtrBase {
 public:
     ResourcePtr() { }
     ResourcePtr(R* res) : ResourcePtrBase(res) { }
     ResourcePtr(const ResourcePtr<R>& o) : ResourcePtrBase(o) { }
-    template<typename U> ResourcePtr(const ResourcePtr<U>& o) : ResourcePtrBase(o.get()) { }
+    template<typename U> ResourcePtr(const ResourcePtr<U>& o) : ResourcePtr(o.get()) { }
 
-    R* get() const { return reinterpret_cast<R*>(ResourcePtrBase::get()); }
+    R* get() const { return static_cast<R*>(ResourcePtrBase::get()); }
     R* operator->() const { return get(); }
 
     ResourcePtr& operator=(R* res) { setResource(res); return *this; }
     ResourcePtr& operator=(const ResourcePtr& o) { setResource(o.get()); return *this; }
-    template<typename U> ResourcePtr& operator=(const ResourcePtr<U>& o) { setResource(o.get()); return *this; }
+    template<typename U> ResourcePtr& operator=(const ResourcePtr<U>& o) { R* r = o.get(); setResource(r); return *this; }
 
     bool operator==(const ResourcePtrBase& o) const { return get() == o.get(); }
     bool operator!=(const ResourcePtrBase& o) const { return get() != o.get(); }
 };
 
 template <class R, class RR> bool operator==(const ResourcePtr<R>& h, const RR* res)
 {
     return h.get() == res;
 }
 template <class R, class RR> bool operator==(const RR* res, const ResourcePtr<R>& h)
 {
     return h.get() == res;
 }
 template <class R, class RR> bool operator!=(const ResourcePtr<R>& h, const RR* res)
 {
     return h.get() != res;
 }
 template <class R, class RR> bool operator!=(const RR* res, const ResourcePtr<R>& h)
 {
     return h.get() != res;
 }
 }
 
 #endif