Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 720673002: Replace generic Dictionary with DictionaryPluginPlaceholderOptions (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace generic Dictionary with DictionaryPluginPlaceholderOptions Dictionary.h has some problems (it cannot handle ExceptionState, difficult to understand). We want to reduce Dictionary uses in core/modules so that make it more maintainable. Tests under fast/plugins cover this change. BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M Source/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/plugins/testing/DictionaryPluginPlaceholder.h View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/testing/Internals.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/testing/PluginPlaceholderOptions.idl View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL?
6 years, 1 month ago (2014-11-12 07:02:15 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-12 07:07:29 UTC) #3
bashi
On 2014/11/12 07:07:29, haraken wrote: > LGTM Thanks!
6 years, 1 month ago (2014-11-12 07:49:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720673002/1
6 years, 1 month ago (2014-11-12 07:50:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 09:12:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185194

Powered by Google App Engine
This is Rietveld 408576698