Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: Source/core/plugins/testing/DictionaryPluginPlaceholder.h

Issue 720673002: Replace generic Dictionary with DictionaryPluginPlaceholderOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/plugins/testing/DictionaryPluginPlaceholder.h
diff --git a/Source/core/plugins/testing/DictionaryPluginPlaceholder.h b/Source/core/plugins/testing/DictionaryPluginPlaceholder.h
index 79124a48b393b5a79f8304cdf2c316d19af369d8..f6fe25d40e968455bf881d4e53de4ff3d8c2ace9 100644
--- a/Source/core/plugins/testing/DictionaryPluginPlaceholder.h
+++ b/Source/core/plugins/testing/DictionaryPluginPlaceholder.h
@@ -5,9 +5,9 @@
#ifndef DictionaryPluginPlaceholder_h
#define DictionaryPluginPlaceholder_h
-#include "bindings/core/v8/Dictionary.h"
#include "core/html/shadow/PluginPlaceholderElement.h"
#include "core/plugins/PluginPlaceholder.h"
+#include "core/testing/PluginPlaceholderOptions.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -17,16 +17,14 @@ namespace blink {
class DictionaryPluginPlaceholder : public NoBaseWillBeGarbageCollected<DictionaryPluginPlaceholder>, public PluginPlaceholder {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DictionaryPluginPlaceholder);
public:
- static PassOwnPtrWillBeRawPtr<DictionaryPluginPlaceholder> create(Document& document, const Dictionary& options)
+ static PassOwnPtrWillBeRawPtr<DictionaryPluginPlaceholder> create(Document& document, const PluginPlaceholderOptions& options)
{
RefPtrWillBeRawPtr<PluginPlaceholderElement> placeholder = PluginPlaceholderElement::create(document);
- String stringValue;
- if (DictionaryHelper::get(options, "message", stringValue))
- placeholder->setMessage(stringValue);
+ if (options.hasMessage())
+ placeholder->setMessage(options.message());
- bool booleanValue;
- if (DictionaryHelper::get(options, "closeable", booleanValue))
- placeholder->setIsCloseable(booleanValue);
+ if (options.hasCloseable())
+ placeholder->setIsCloseable(options.closeable());
return adoptPtrWillBeNoop(new DictionaryPluginPlaceholder(placeholder.release()));
}
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698