[NaCl SDK] Convert python scripts from optparse to argparse.

[NaCl SDK] Convert python scripts from optparse to argparse.

None of these changes should change the behaviour of the
scripts with the exception of rst_index.py which now takes
both output and input as positional parameters since they
are both required.

TEST=./test_all.py

Committed: https://crrev.com/22adb217d481d9a2115daab9caecd9d93aff8370
Cr-Commit-Position: refs/heads/master@{#311477}

[Sam Clegg, 2014-11-13 19:09:20]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-11-13 23:57:05]

In general, there is a lot of churn here, and a lot of chances for errors... I
wonder if it is worth it.

But I'm kinda on the fence on this, so if you feel strongly OK.

Though the lack of tests for some of these scripts makes me nervous -- I noticed
a few that look broken.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_app.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_app.py:12: if sys.version_info < (2, 6,
0):
bump all of these to 2.7.0

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_projects.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_projects.py:7: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_updater.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_updater.py:15: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/dsc2gyp.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/dsc2gyp.py:8: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/easy_template.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:8: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:105: with
open(options.templet) as f:
template

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/generate_notice.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/generate_notice.py:76:
parser.add_argument('files')
nargs='*'

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/parse_dsc.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/parse_dsc.py:8: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py:1: #!/usr/bin/env
python
I'd prefer doing the sdk_updater as a separate CL. It has a more complex
argument parsing scheme, and is used by external users (so maybe we don't want
to update it to 2.7 yet)

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/test_projects.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/test_projects.py:329:
parser.add_argument('projects')
nargs='*'

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/update_nacl_manifest.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/update_nacl_manifest.py:21: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/update_sdktools.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/update_sdktools.py:22: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/verify_filelist.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/verify_filelist.py:213:
sys.stderr.write('Error parsing rules:\n%s' % e)
additional \n after %s

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/verify_ppapi.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/verify_ppapi.py:172: parser =
argparse.ArgumentParser(usage=usage, description=description)
I think this one needs more changes (remove usage, add "file" argument, etc.)

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/doxy_cleanup.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/doxy_cleanup.py:12: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/doxy_cleanup.py:151: def main(argv):
rename to args

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/doxy_cleanup.py:157: parser =
argparse.ArgumentParser(usage='Usage: %prog [options] directory')
remove usage?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/generate_docs.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:11: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:296: help='Verbose output',
action='store_true')
nit: align

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:297:
parser.add_argument('dir')
better name: out_directory?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/rst_index.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/rst_index.py:8: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/rst_index.py:230: parser =
argparse.ArgumentParser(description=__doc__)
no doc?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/te...
File native_client_sdk/src/test_all.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/test_all.py:62: print(cmd)
why?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_html.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_html.py:22: 
add a python 2.7 check?

Looks like the docs say 2.6 or 2.7 is OK, so that should be changed too.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:14: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:469: if not
os.path.exists(os.path.join(directory, 'toolchain')):
just 

    return os.path.exists(...)

?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:480: if sdk_root:
Is this change necessary?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:486: # attempt to drive the root.
sp: derive

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/decode_dump.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:12: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:181: usage='USAGE: %prog [options]
<core.json>')
remove usage

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:193: options, args =
parser.parse_args(args)
options = ...

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:194: if len(args) != 1:
add positional arg

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/fix_deps.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_deps.py:16: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/fix_manifest.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:39: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:43: if sys.version_info < (2, 6, 0):
2.7

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:62: usage='Usage: %prog [options]
manifest.json', description=__doc__)
remove usage

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:71: options, args =
parser.parse_args(argv)
options =

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:75: if not args:
remove

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/genhttpfs.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:15: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:26: usage='Usage: %prog [options]
<filename>...')
remove usage

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:36: options, args =
parser.parse_args(argv)
options =

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:46: if not args:
add positional args

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/getos.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/getos.py:239: options, _ = parser.parse_args(args)
fix

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/httpd.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:9: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:17: if sys.version_info < (2, 6, 0):
2.7

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:207: options, args =
parser.parse_args(args)
fix

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/lib/tests/quote_test.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/lib/tests/quote_test.py:114: options, args =
parser.parse_args(argv)
fix

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/ncval.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/ncval.py:35: parser.add_argument('args',
metavar="EXE", nargs='+',
exes?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:113: parser =
argparse.ArgumentParser(usage='cp [Options] sources... dest')
use doc?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:128: parser.add_argument('src',
nargs='+', help='files to copy')
srcs

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:152: parser =
argparse.ArgumentParser(usage='mkdir [Options] DIRECTORY...')
use doc?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:161: parser.add_argument('dirs',
nargs='+', help='directoy to create')
sp: directories

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:206: else:
I find for/else confusing, but OK

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:212: parser =
argparse.ArgumentParser(usage='mv [Options] sources... dest')
use doc?

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:221: parser.add_argument('source',
nargs='+')
srcs

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/run.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:9: This command creates a local server on an
ephemeral port, then runs:
not true anymore. 5103 is the default

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:17: import argparse
sort

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:24: if sys.version_info < (2, 6, 0):
2.7

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:45: parser.add_argument('args', nargs='+',
help='arguments for executable')
this should probably be separated into two args: exe, args for exe

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/tests/create_nmf_test.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/tests/create_nmf_test.py:75:
@patch('create_nmf.IsValidSDKRoot', Mock(return_value=True))
seems unrelated

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/tests/httpd_test.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/tests/httpd_test.py:50: cmd = [sys.executable,
os.path.join(PARENT_DIR, 'run.py')]
seems unrelated

[Sam Clegg, 2014-11-15 02:28:25]

OK, I'm going to split this into 3 changes and leave this once for just the
argparse stuff.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_app.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_app.py:12: if sys.version_info < (2, 6,
0):
On 2014/11/13 23:57:01, binji wrote:
> bump all of these to 2.7.0

Split this into a separate change

[Sam Clegg, 2014-11-30 17:55:14]

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_projects.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_projects.py:7: import argparse
On 2014/11/13 23:57:01, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/build_updater.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/build_updater.py:15: import argparse
On 2014/11/13 23:57:01, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/dsc2gyp.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/dsc2gyp.py:8: import argparse
On 2014/11/13 23:57:01, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/easy_template.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:8: import argparse
On 2014/11/13 23:57:01, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:105: with
open(options.templet) as f:
On 2014/11/13 23:57:01, binji wrote:
> template

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/generate_notice.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/generate_notice.py:76:
parser.add_argument('files')
On 2014/11/13 23:57:01, binji wrote:
> nargs='*'

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/parse_dsc.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/parse_dsc.py:8: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py:1: #!/usr/bin/env
python
On 2014/11/13 23:57:02, binji wrote:
> I'd prefer doing the sdk_updater as a separate CL. It has a more complex
> argument parsing scheme, and is used by external users (so maybe we don't want
> to update it to 2.7 yet)

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/test_projects.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/test_projects.py:329:
parser.add_argument('projects')
On 2014/11/13 23:57:02, binji wrote:
> nargs='*'

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/update_nacl_manifest.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/update_nacl_manifest.py:21: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/update_sdktools.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/update_sdktools.py:22: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/verify_filelist.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/verify_filelist.py:213:
sys.stderr.write('Error parsing rules:\n%s' % e)
On 2014/11/13 23:57:02, binji wrote:
> additional \n after %s

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/verify_ppapi.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/verify_ppapi.py:172: parser =
argparse.ArgumentParser(usage=usage, description=description)
On 2014/11/13 23:57:02, binji wrote:
> I think this one needs more changes (remove usage, add "file" argument, etc.)

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/doxy_cleanup.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/doxy_cleanup.py:12: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/doxy_cleanup.py:157: parser =
argparse.ArgumentParser(usage='Usage: %prog [options] directory')
On 2014/11/13 23:57:02, binji wrote:
> remove usage?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/generate_docs.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:11: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:296: help='Verbose output',
action='store_true')
On 2014/11/13 23:57:02, binji wrote:
> nit: align

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/generate_docs.py:297:
parser.add_argument('dir')
On 2014/11/13 23:57:02, binji wrote:
> better name: out_directory?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/doxygen/rst_index.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/rst_index.py:8: import argparse
On 2014/11/13 23:57:02, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/doxygen/rst_index.py:230: parser =
argparse.ArgumentParser(description=__doc__)
On 2014/11/13 23:57:02, binji wrote:
> no doc?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/te...
File native_client_sdk/src/test_all.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/te...
native_client_sdk/src/test_all.py:62: print(cmd)
On 2014/11/13 23:57:02, binji wrote:
> why?

Dropped.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_html.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_html.py:22: 
On 2014/11/13 23:57:03, binji wrote:
> add a python 2.7 check?
> 
> Looks like the docs say 2.6 or 2.7 is OK, so that should be changed too.

Done in separate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:14: import argparse
On 2014/11/13 23:57:03, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:469: if not
os.path.exists(os.path.join(directory, 'toolchain')):
On 2014/11/13 23:57:03, binji wrote:
> just 
> 
>     return os.path.exists(...)
> 
> ?

Split into seperate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:480: if sdk_root:
On 2014/11/13 23:57:03, binji wrote:
> Is this change necessary?

Separate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/create_nmf.py:486: # attempt to drive the root.
On 2014/11/13 23:57:03, binji wrote:
> sp: derive

Separate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/decode_dump.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:12: import argparse
On 2014/11/13 23:57:03, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:181: usage='USAGE: %prog [options]
<core.json>')
On 2014/11/13 23:57:03, binji wrote:
> remove usage

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:193: options, args =
parser.parse_args(args)
On 2014/11/13 23:57:03, binji wrote:
> options = ...

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/decode_dump.py:194: if len(args) != 1:
On 2014/11/13 23:57:03, binji wrote:
> add positional arg

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/fix_manifest.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:39: import argparse
On 2014/11/13 23:57:03, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:43: if sys.version_info < (2, 6, 0):
On 2014/11/13 23:57:03, binji wrote:
> 2.7

Separate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:62: usage='Usage: %prog [options]
manifest.json', description=__doc__)
On 2014/11/13 23:57:03, binji wrote:
> remove usage

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:71: options, args =
parser.parse_args(argv)
On 2014/11/13 23:57:03, binji wrote:
> options = 

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/fix_manifest.py:75: if not args:
On 2014/11/13 23:57:03, binji wrote:
> remove

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/genhttpfs.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:15: import argparse
On 2014/11/13 23:57:04, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:26: usage='Usage: %prog [options]
<filename>...')
On 2014/11/13 23:57:04, binji wrote:
> remove usage

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:36: options, args =
parser.parse_args(argv)
On 2014/11/13 23:57:04, binji wrote:
> options = 

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/genhttpfs.py:46: if not args:
On 2014/11/13 23:57:03, binji wrote:
> add positional args

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/getos.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/getos.py:239: options, _ = parser.parse_args(args)
On 2014/11/13 23:57:04, binji wrote:
> fix

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/httpd.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:9: import argparse
On 2014/11/13 23:57:04, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:17: if sys.version_info < (2, 6, 0):
On 2014/11/13 23:57:04, binji wrote:
> 2.7

Seperate CL

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/httpd.py:207: options, args =
parser.parse_args(args)
On 2014/11/13 23:57:04, binji wrote:
> fix

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/ncval.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/ncval.py:35: parser.add_argument('args',
metavar="EXE", nargs='+',
On 2014/11/13 23:57:04, binji wrote:
> exes?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:113: parser =
argparse.ArgumentParser(usage='cp [Options] sources... dest')
On 2014/11/13 23:57:04, binji wrote:
> use doc?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:128: parser.add_argument('src',
nargs='+', help='files to copy')
On 2014/11/13 23:57:04, binji wrote:
> srcs

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:152: parser =
argparse.ArgumentParser(usage='mkdir [Options] DIRECTORY...')
On 2014/11/13 23:57:04, binji wrote:
> use doc?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:161: parser.add_argument('dirs',
nargs='+', help='directoy to create')
On 2014/11/13 23:57:04, binji wrote:
> sp: directories

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:206: else:
On 2014/11/13 23:57:04, binji wrote:
> I find for/else confusing, but OK

I will re-write this as a function and/or context manager in another CL.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/oshelpers.py:212: parser =
argparse.ArgumentParser(usage='mv [Options] sources... dest')
On 2014/11/13 23:57:04, binji wrote:
> use doc?

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/run.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:9: This command creates a local server on an
ephemeral port, then runs:
On 2014/11/13 23:57:05, binji wrote:
> not true anymore. 5103 is the default

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:17: import argparse
On 2014/11/13 23:57:04, binji wrote:
> sort

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:24: if sys.version_info < (2, 6, 0):
On 2014/11/13 23:57:04, binji wrote:
> 2.7

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/run.py:45: parser.add_argument('args', nargs='+',
help='arguments for executable')
On 2014/11/13 23:57:05, binji wrote:
> this should probably be separated into two args: exe, args for exe

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/tests/create_nmf_test.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/tests/create_nmf_test.py:75:
@patch('create_nmf.IsValidSDKRoot', Mock(return_value=True))
On 2014/11/13 23:57:05, binji wrote:
> seems unrelated

Done.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
File native_client_sdk/src/tools/tests/httpd_test.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/to...
native_client_sdk/src/tools/tests/httpd_test.py:50: cmd = [sys.executable,
os.path.join(PARENT_DIR, 'run.py')]
On 2014/11/13 23:57:05, binji wrote:
> seems unrelated

Done.

[binji, 2014-12-08 21:58:20]

lgtm

I'm still a little concerned that we don't have sufficient test coverage for
these changes, but I guess we'll catch the issues manually.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/easy_template.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:105: with
open(options.templet) as f:
On 2014/11/30 17:55:11, Sam Clegg wrote:
> On 2014/11/13 23:57:01, binji wrote:
> > template
> 
> Done.

template :)

https://codereview.chromium.org/720233003/diff/180001/native_client_sdk/src/t...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/720233003/diff/180001/native_client_sdk/src/t...
native_client_sdk/src/tools/create_nmf.py:608: print(str(sys.argv))
remove?

[Sam Clegg, 2015-01-14 15:28:32]

Added more test coverage of the arg parsing.

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
File native_client_sdk/src/build_tools/easy_template.py (right):

https://codereview.chromium.org/720233003/diff/20001/native_client_sdk/src/bu...
native_client_sdk/src/build_tools/easy_template.py:105: with
open(options.templet) as f:
On 2014/12/08 21:58:20, binji wrote:
> On 2014/11/30 17:55:11, Sam Clegg wrote:
> > On 2014/11/13 23:57:01, binji wrote:
> > > template
> > 
> > Done.
> 
> template :)

Done.

https://codereview.chromium.org/720233003/diff/180001/native_client_sdk/src/t...
File native_client_sdk/src/tools/create_nmf.py (right):

https://codereview.chromium.org/720233003/diff/180001/native_client_sdk/src/t...
native_client_sdk/src/tools/create_nmf.py:608: print(str(sys.argv))
On 2014/12/08 21:58:20, binji wrote:
> remove?

Done.

[Sam Clegg, 2015-01-14 15:28:53]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-01-14 15:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/720233003/220001

[commit-bot: I haz the power, 2015-01-14 15:30:41]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-01-14 15:31:51]

Patchset 12 (id:??) landed as
https://crrev.com/22adb217d481d9a2115daab9caecd9d93aff8370
Cr-Commit-Position: refs/heads/master@{#311477}