Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: native_client_sdk/src/tools/decode_dump.py

Issue 720233003: [NaCl SDK] Convert python scripts from optparse to argparse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tools/create_nmf.py ('k') | native_client_sdk/src/tools/fix_deps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tools/decode_dump.py
diff --git a/native_client_sdk/src/tools/decode_dump.py b/native_client_sdk/src/tools/decode_dump.py
index b16a8e25048a61a7bebea5c6e4762743ca196961..60bf70210fb6b30215238e5b710c66995a629e63 100755
--- a/native_client_sdk/src/tools/decode_dump.py
+++ b/native_client_sdk/src/tools/decode_dump.py
@@ -8,8 +8,8 @@
Currently this produces a simple stack trace.
"""
+import argparse
import json
-import optparse
import os
import posixpath
import subprocess
@@ -176,30 +176,27 @@ class CoreDecoder(object):
def main(args):
- parser = optparse.OptionParser(
- usage='USAGE: %prog [options] <core.json>')
- parser.add_option('-m', '--main-nexe', dest='main_nexe',
- help='nexe to resolve NaClMain references from')
- parser.add_option('-n', '--nmf', dest='nmf_filename', default='-',
- help='nmf to resolve references from')
- parser.add_option('-a', '--addr2line', dest='addr2line',
- help='path to appropriate addr2line')
- parser.add_option('-L', '--library-path', dest='library_paths',
- action='append', default=[],
- help='path to search for shared libraries')
- parser.add_option('-p', '--platform', dest='platform',
- help='platform in a style match nmf files')
- options, args = parser.parse_args(args)
- if len(args) != 1:
- parser.print_help()
- sys.exit(1)
+ parser = argparse.ArgumentParser(description=__doc__)
+ parser.add_argument('-m', '--main-nexe',
+ help='nexe to resolve NaClMain references from')
+ parser.add_argument('-n', '--nmf', default='-',
+ help='nmf to resolve references from')
+ parser.add_argument('-a', '--addr2line',
+ help='path to appropriate addr2line')
+ parser.add_argument('-L', '--library-path', dest='library_paths',
+ action='append', default=[],
+ help='path to search for shared libraries')
+ parser.add_argument('-p', '--platform',
+ help='platform in a style match nmf files')
+ parser.add_argument('core_json')
+ options = parser.parse_args(args)
decoder = CoreDecoder(
main_nexe=options.main_nexe,
- nmf_filename=options.nmf_filename,
- addr2line=options.add2line,
+ nmf_filename=options.nmf,
+ addr2line=options.addr2line,
library_paths=options.library_paths,
platform=options.platform)
- info = decoder.LoadAndDecode(args[0])
+ info = decoder.LoadAndDecode(options.core_json)
trace = decoder.StackTrace(info)
decoder.PrintTrace(trace, sys.stdout)
return 0
« no previous file with comments | « native_client_sdk/src/tools/create_nmf.py ('k') | native_client_sdk/src/tools/fix_deps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698