Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed)

Created:
6 years, 1 month ago by pfeldman
Modified:
6 years, 1 month ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: only allow status bar items in status bars. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185368

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -252 lines) Patch
M LayoutTests/inspector/extensions/extensions-panel.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 4 chunks +20 lines, -11 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 3 chunks +4 lines, -24 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 6 chunks +12 lines, -17 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 4 chunks +10 lines, -9 lines 0 comments Download
M Source/devtools/front_end/profiler/CanvasProfileView.js View 1 5 chunks +25 lines, -19 lines 0 comments Download
M Source/devtools/front_end/profiler/CanvasReplayStateView.js View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 2 7 chunks +23 lines, -24 lines 0 comments Download
M Source/devtools/front_end/profiler/profilesPanel.css View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/promises/PromisePane.js View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 2 chunks +11 lines, -6 lines 0 comments Download
M Source/devtools/front_end/resources/CookieItemsView.js View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/DOMStorageItemsView.js View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/DatabaseQueryView.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/resources/DatabaseTableView.js View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/FileSystemView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/resources/IndexedDBViews.js View 4 chunks +23 lines, -19 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 4 chunks +16 lines, -8 lines 0 comments Download
M Source/devtools/front_end/resources/indexedDBViews.css View 1 chunk +22 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/resourcesPanel.css View 1 chunk +1 line, -14 lines 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 chunks +29 lines, -32 lines 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/StatusBarButton.js View 1 8 chunks +79 lines, -19 lines 0 comments Download
M Source/devtools/front_end/ui/filter.css View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pfeldman
6 years, 1 month ago (2014-11-13 18:06:07 UTC) #2
apavlov
lgtm, yet I think we could simplify the StatusBar method names to make it resemble ...
6 years, 1 month ago (2014-11-14 09:36:08 UTC) #3
pfeldman
https://codereview.chromium.org/720223002/diff/20001/Source/devtools/front_end/extensions/ExtensionPanel.js File Source/devtools/front_end/extensions/ExtensionPanel.js (right): https://codereview.chromium.org/720223002/diff/20001/Source/devtools/front_end/extensions/ExtensionPanel.js#newcode71 Source/devtools/front_end/extensions/ExtensionPanel.js:71: this._panelStatusBar.appendStatusBarItem(item); I'm planning to rename the whole thing. https://codereview.chromium.org/720223002/diff/20001/Source/devtools/front_end/profiler/ProfilesPanel.js ...
6 years, 1 month ago (2014-11-14 09:37:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720223002/40001
6 years, 1 month ago (2014-11-14 09:44:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36523)
6 years, 1 month ago (2014-11-14 11:57:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720223002/40001
6 years, 1 month ago (2014-11-14 12:04:11 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 12:05:05 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185368

Powered by Google App Engine
This is Rietveld 408576698