Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: Source/devtools/front_end/resources/IndexedDBViews.js

Issue 720223002: DevTools: only allow status bar items in status bars. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/resources/IndexedDBViews.js
diff --git a/Source/devtools/front_end/resources/IndexedDBViews.js b/Source/devtools/front_end/resources/IndexedDBViews.js
index a74e19a0fa4717805c6fc7d3cbff064da5425be4..bf2b7eacda14e256190828a8486b444206fcaa5b 100644
--- a/Source/devtools/front_end/resources/IndexedDBViews.js
+++ b/Source/devtools/front_end/resources/IndexedDBViews.js
@@ -65,6 +65,14 @@ WebInspector.IDBDatabaseView = function(database)
WebInspector.IDBDatabaseView.prototype = {
/**
+ * @return {!Array.<!WebInspector.StatusBarItem>}
+ */
+ statusBarItems: function()
+ {
+ return [];
+ },
+
+ /**
* @param {string} name
* @param {string} value
*/
@@ -207,21 +215,14 @@ WebInspector.IDBDataView.prototype = {
editorToolbar.classList.add("status-bar");
editorToolbar.classList.add("data-view-toolbar");
- this._pageBackButton = editorToolbar.createChild("button", "back-button");
- this._pageBackButton.classList.add("status-bar-item");
- this._pageBackButton.title = WebInspector.UIString("Show previous page.");
- this._pageBackButton.disabled = true;
- this._pageBackButton.appendChild(createElement("img"));
- this._pageBackButton.addEventListener("click", this._pageBackButtonClicked.bind(this), false);
- editorToolbar.appendChild(this._pageBackButton);
-
- this._pageForwardButton = editorToolbar.createChild("button", "forward-button");
- this._pageForwardButton.classList.add("status-bar-item");
- this._pageForwardButton.title = WebInspector.UIString("Show next page.");
- this._pageForwardButton.disabled = true;
- this._pageForwardButton.appendChild(createElement("img"));
- this._pageForwardButton.addEventListener("click", this._pageForwardButtonClicked.bind(this), false);
- editorToolbar.appendChild(this._pageForwardButton);
+ this._pageBackButton = new WebInspector.StatusBarButton(WebInspector.UIString("Show previous page."), "indexed-db-status-bar-back-button");
+ this._pageBackButton.addEventListener("click", this._pageBackButtonClicked, this);
+ editorToolbar.appendChild(this._pageBackButton.element);
+
+ this._pageForwardButton = new WebInspector.StatusBarButton(WebInspector.UIString("Show next page."), "indexed-db-status-bar-forward-button");
+ this._pageForwardButton.setEnabled(false);
+ this._pageForwardButton.addEventListener("click", this._pageForwardButtonClicked, this);
+ editorToolbar.appendChild(this._pageForwardButton.element);
this._keyInputElement = editorToolbar.createChild("input", "key-input");
this._keyInputElement.placeholder = WebInspector.UIString("Start from key");
@@ -326,8 +327,8 @@ WebInspector.IDBDataView.prototype = {
this._dataGrid.rootNode().appendChild(node);
}
- this._pageBackButton.disabled = skipCount === 0;
- this._pageForwardButton.disabled = !hasMore;
+ this._pageBackButton.setEnabled(!!skipCount);
+ this._pageForwardButton.setEnabled(hasMore);
}
var idbKeyRange = key ? window.IDBKeyRange.lowerBound(key) : null;
@@ -355,9 +356,12 @@ WebInspector.IDBDataView.prototype = {
this._model.clearObjectStore(this._databaseId, this._objectStore.name, cleared.bind(this));
},
- get statusBarItems()
+ /**
+ * @return {!Array.<!WebInspector.StatusBarItem>}
+ */
+ statusBarItems: function()
{
- return [this._refreshButton.element, this._clearButton.element];
+ return [this._refreshButton, this._clearButton];
},
clear: function()
« no previous file with comments | « Source/devtools/front_end/resources/FileSystemView.js ('k') | Source/devtools/front_end/resources/ResourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698