Issue 720213002: Rename onCreateDevice -> onCreateCompatibleDevice

Issue 720213002: Rename onCreateDevice -> onCreateCompatibleDevice (Closed)

Created:
6 years, 1 month ago by f(malita)

Modified:
6 years, 1 month ago

Reviewers:
reed1

CC:
reviews_skia.org, jcgregorio

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Rename onCreateDevice -> onCreateCompatibleDevice This is a port of https://codereview.chromium.org/723743002/ with the following changes: * drop the legacy onCreateDevice variant completely * also convert SkXPSDevice & SkGatherPixelRefsAndRects to the new API This is expected to break canaries and will require a manual/cowboy roll. TBR=reed@google.com NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/6987dcaf257dd7c2c8e0014cf7452fde82bcba5b

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -38 lines)			Patch
M	include/core/SkBitmapDevice.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/core/SkDevice.h	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	include/device/xps/SkXPSDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/device/xps/SkXPSDevice.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/SkGpuDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/utils/SkDeferredCanvas.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/utils/SkGatherPixelRefsAndRects.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/utils/SkPictureUtils.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

f(malita)

This should roll with https://codereview.chromium.org/718243002/

6 years, 1 month ago (2014-11-13 15:19:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720213002/1

6 years, 1 month ago (2014-11-13 16:32:31 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 16:33:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6987dcaf257dd7c2c8e0014cf7452fde82bcba5b