Source/core/svg/SVGAnimatedLengthList.h - Issue 720113003: bindings: Makes SVGAnimatedProperty ScriptWrappable.

Unified Diff: Source/core/svg/SVGAnimatedLengthList.h

Issue 720113003: bindings: Makes SVGAnimatedProperty ScriptWrappable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptWrappable.h ('K') | « Source/core/svg/SVGAnimatedLength.idl ('k') | Source/core/svg/SVGAnimatedLengthList.idl » ('j') | Source/core/svg/SVGAnimatedNumberList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGAnimatedLengthList.h

diff --git a/Source/core/svg/SVGAnimatedLengthList.h b/Source/core/svg/SVGAnimatedLengthList.h

index 9ac0eb565941e2a90efc30468c700c109953910f..3975826ef35b20895440019f63efdbe710decdea 100644

--- a/Source/core/svg/SVGAnimatedLengthList.h

+++ b/Source/core/svg/SVGAnimatedLengthList.h

@@ -36,7 +36,19 @@

namespace blink {

-typedef SVGAnimatedProperty<SVGLengthList> SVGAnimatedLengthList;

+// SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedLengthList

+class SVGAnimatedLengthList : public SVGAnimatedProperty<SVGLengthList> {

haraken 2014/11/13 07:46:37 Add final.

Yuki 2014/11/13 08:16:38 Done.

+ DEFINE_WRAPPERTYPEINFO();

+public:

+ static PassRefPtr<SVGAnimatedLengthList> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGLengthList> initialValue)

haraken 2014/11/13 07:46:37 PassRefPtr => PassRefPtrWillBeRawPtr?

Yuki 2014/11/13 08:16:38 SVGAnimatedLength is using PassRefPtr. Is it reall

Yuki 2014/11/13 08:30:00 Sorry, I synced up to the head, and I found things

+ {

+ return adoptRef(new SVGAnimatedLengthList(contextElement, attributeName, initialValue));

haraken 2014/11/13 07:46:37 adoptRef => adoptRefWillBeNoop ?

Yuki 2014/11/13 08:30:00 Done.

+ }

+protected:

+ SVGAnimatedLengthList(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGLengthList> initialValue)

haraken 2014/11/13 07:46:37 PassRefPtr => PassRefPtrWillBeRawPtr?

Yuki 2014/11/13 08:30:00 Done.

+ : SVGAnimatedProperty<SVGLengthList>(contextElement, attributeName, initialValue) { }

+};

} // namespace blink