Source/core/svg/SVGAnimatedLengthList.h - Issue 720113003: bindings: Makes SVGAnimatedProperty ScriptWrappable.

Side by Side Diff: Source/core/svg/SVGAnimatedLengthList.h

Issue 720113003: bindings: Makes SVGAnimatedProperty ScriptWrappable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 18 matching lines...) Expand all Loading...
29 */	29 */

30	30

31 #ifndef SVGAnimatedLengthList_h	31 #ifndef SVGAnimatedLengthList_h

32 #define SVGAnimatedLengthList_h	32 #define SVGAnimatedLengthList_h

33	33

34 #include "core/svg/SVGLengthListTearOff.h"	34 #include "core/svg/SVGLengthListTearOff.h"

35 #include "core/svg/properties/SVGAnimatedProperty.h"	35 #include "core/svg/properties/SVGAnimatedProperty.h"

36	36

37 namespace blink {	37 namespace blink {

38	38

39 typedef SVGAnimatedProperty<SVGLengthList> SVGAnimatedLengthList;	39 // SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedLengthLis t

	40 class SVGAnimatedLengthList : public SVGAnimatedProperty<SVGLengthList> {
	haraken 2014/11/13 07:46:37 Add final. Add final. Yuki 2014/11/13 08:16:38 Done. Show quoted text On 2014/11/13 07:46:37, haraken wrote: > > Add final. Done.
	41 DEFINE_WRAPPERTYPEINFO();

	42 public:

	43 static PassRefPtr<SVGAnimatedLengthList> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGLengthList> initialValue)
	haraken 2014/11/13 07:46:37 PassRefPtr => PassRefPtrWillBeRawPtr? PassRefPtr => PassRefPtrWillBeRawPtr? Yuki 2014/11/13 08:16:38 SVGAnimatedLength is using PassRefPtr. Is it reall Show quoted text On 2014/11/13 07:46:37, haraken wrote: > > PassRefPtr => PassRefPtrWillBeRawPtr? SVGAnimatedLength is using PassRefPtr. Is it really okay to rewrite to PassRefPtrWillBeRawPtr? Yuki 2014/11/13 08:30:00 Sorry, I synced up to the head, and I found things Show quoted text On 2014/11/13 08:16:38, Yuki wrote: > On 2014/11/13 07:46:37, haraken wrote: > > > > PassRefPtr => PassRefPtrWillBeRawPtr? > > SVGAnimatedLength is using PassRefPtr. > Is it really okay to rewrite to PassRefPtrWillBeRawPtr? Sorry, I synced up to the head, and I found things changed. Follow your comments.
	44 {

	45 return adoptRef(new SVGAnimatedLengthList(contextElement, attributeName, initialValue));
	haraken 2014/11/13 07:46:37 adoptRef => adoptRefWillBeNoop ? adoptRef => adoptRefWillBeNoop ? Yuki 2014/11/13 08:30:00 Done. Show quoted text On 2014/11/13 07:46:37, haraken wrote: > > adoptRef => adoptRefWillBeNoop ? Done.
	46 }

	47

	48 protected:

	49 SVGAnimatedLengthList(SVGElement* contextElement, const QualifiedName& attri buteName, PassRefPtr<SVGLengthList> initialValue)
	haraken 2014/11/13 07:46:37 PassRefPtr => PassRefPtrWillBeRawPtr? PassRefPtr => PassRefPtrWillBeRawPtr? Yuki 2014/11/13 08:30:00 Done. Show quoted text On 2014/11/13 07:46:37, haraken wrote: > > PassRefPtr => PassRefPtrWillBeRawPtr? Done.
	50 : SVGAnimatedProperty<SVGLengthList>(contextElement, attributeName, init ialValue) { }

	51 };

40	52

41 } // namespace blink	53 } // namespace blink

42	54

43 #endif	55 #endif

OLD	NEW