Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 7200040: Pass through PDFs from the plugin when using Skia on the Mac. (Closed)

Created:
9 years, 6 months ago by vandebo (ex-Chrome)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, _cary
Visibility:
Public.

Description

Pass through PDFs from the plugin when using Skia on the Mac. * Don't make a single PDF, the mac print workflow expects one pdf per page. * It looks like the margin is getting applied twice, but that's another issue. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91173

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Fix crash #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 6 chunks +8 lines, -14 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
vandebo (ex-Chrome)
9 years, 5 months ago (2011-06-30 17:33:21 UTC) #1
kmadhusu
LGTM with a nit.
9 years, 5 months ago (2011-06-30 17:57:31 UTC) #2
kmadhusu
LGTM with a nit. http://codereview.chromium.org/7200040/diff/5001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): http://codereview.chromium.org/7200040/diff/5001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode81 webkit/plugins/ppapi/ppapi_plugin_instance.cc:81: #endif nit: #endif // USE_SKIA
9 years, 5 months ago (2011-06-30 17:58:09 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-06-30 19:01:26 UTC) #4
Change committed as 91173

Powered by Google App Engine
This is Rietveld 408576698