Issue 7200040: Pass through PDFs from the plugin when using Skia on the Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7200040: Pass through PDFs from the plugin when using Skia on the Mac. (Closed)

Created:
9 years, 6 months ago by vandebo (ex-Chrome)

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, kmadhusu

CC:
chromium-reviews, darin-cc_chromium.org, _cary

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pass through PDFs from the plugin when using Skia on the Mac. * Don't make a single PDF, the mac print workflow expects one pdf per page. * It looks like the margin is getting applied twice, but that's another issue. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91173

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Fix crash #

Total comments: 1

Created: 9 years, 5 months ago

		Unified diffs	Side-by-side diffs	Stats (+10 lines, -16 lines)
	M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	2 chunks	+2 lines, -2 lines	0 comments
	M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	6 chunks	+8 lines, -14 lines	1 comment

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

LGTM with a nit. http://codereview.chromium.org/7200040/diff/5001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): http://codereview.chromium.org/7200040/diff/5001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode81 webkit/plugins/ppapi/ppapi_plugin_instance.cc:81: #endif nit: #endif // USE_SKIA

9 years, 5 months ago (2011-06-30 17:58:09 UTC) #3

Change committed as 91173

Expand Messages | Collapse Messages