Issue 719483002: Merge to M-40 2214: Support vertical centering of multi-line labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 719483002: Merge to M-40 2214: Support vertical centering of multi-line labels. (Closed)

Created:
6 years, 1 month ago by msw

Modified:
6 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

Merge to M-40 2214: Support vertical centering of multi-line labels. Restore naive vertical centering for multi-line Labels. Restore multi-line label unit test expectations. Multi-line labels in horizontal box layouts regressed in: https://chromium.googlesource.com/chromium/src/+/6060457aff422c0202da9fa0ed1f6243394a5fb1 This does not regress the original baseline fix. See screenshots at http://crbug.com/429595#c17 BUG=429595 TEST=page info bubble, other labels are vertically centered. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/712003005 Cr-Commit-Position: refs/heads/master@{#303526} (cherry picked from commit 9a0f2e91d842259250a428b773aab66db096c73b) Committed: https://chromium.googlesource.com/chromium/src/+/22c1e206e8a0507efcd545abb395cc28e9573f18

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
	M	ui/views/controls/label.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	ui/views/controls/label_unittest.cc	View		12 chunks	+21 lines, -21 lines	0 comments	Download

Total messages: 2 (0 generated)

msw

6 years, 1 month ago (2014-11-11 21:39:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
22c1e206e8a0507efcd545abb395cc28e9573f18 (presubmit successful).