Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 712003005: Support vertical centering of multi-line labels. (Closed)

Created:
6 years, 1 month ago by msw
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support vertical centering of multi-line labels. Restore naive vertical centering for multi-line Labels. Restore multi-line label unit test expectations. Multi-line labels in horizontal box layouts regressed in: https://chromium.googlesource.com/chromium/src/+/6060457aff422c0202da9fa0ed1f6243394a5fb1 This does not regress the original baseline fix. See screenshots at http://crbug.com/429595#c17 BUG=429595 TEST=page info bubble, other labels are vertically centered. R=sky@chromium.org Committed: https://crrev.com/9a0f2e91d842259250a428b773aab66db096c73b Cr-Commit-Position: refs/heads/master@{#303526}

Patch Set 1 #

Patch Set 2 : Update multi-line label unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M ui/views/controls/label.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/controls/label_unittest.cc View 1 12 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
msw
Hey Scott, please take a look, thanks!
6 years, 1 month ago (2014-11-10 20:00:25 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-11-10 20:06:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712003005/1
6 years, 1 month ago (2014-11-10 20:08:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712003005/20001
6 years, 1 month ago (2014-11-10 20:34:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20758)
6 years, 1 month ago (2014-11-10 21:14:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712003005/20001
6 years, 1 month ago (2014-11-10 22:28:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-10 22:49:45 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 22:50:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a0f2e91d842259250a428b773aab66db096c73b
Cr-Commit-Position: refs/heads/master@{#303526}

Powered by Google App Engine
This is Rietveld 408576698