Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 719463003: Presubmit checks for user actions intorduced in HTML files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/extract_actions.py
diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py
index 63818f331165614dd04354261943a16ccd6b93bd..5d33d34d244f1f4c80a80d9dc7469a5d632c3594 100755
--- a/tools/metrics/actions/extract_actions.py
+++ b/tools/metrics/actions/extract_actions.py
@@ -506,7 +506,7 @@ def WalkDirectory(root_path, actions, extensions, callback):
dirs.remove('.git')
for file in files:
ext = os.path.splitext(file)[1]
- if ext in extensions:
+ if ext and ext in extensions:
callback(os.path.join(path, file), actions)
def AddLiteralActions(actions):
@@ -763,7 +763,6 @@ def PrettyPrint(actions, actions_dict, comment_nodes=[]):
return print_style.GetPrintStyle().PrettyPrintNode(doc)
-
Alexei Svitkine (slow) 2014/11/11 20:36:41 Nit: Revert changes to this file.
gayane -on leave until 09-2017 2014/11/12 22:00:23 I agree I should restore this line, but the other
def main(argv):
presubmit = ('--presubmit' in argv)
actions_xml_path = os.path.join(path_utils.ScriptDir(), 'actions.xml')
« chrome/browser/resources/PRESUBMIT.py ('K') | « chrome/browser/resources/PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698