Presubmit checks for user actions intorduced in HTML files.

tools/metrics/actions/extract_actions.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
@@ skipping 488 matching lines @@
       parser.close()
 
 def WalkDirectory(root_path, actions, extensions, callback):
   for path, dirs, files in os.walk(root_path):
     if '.svn' in dirs:
       dirs.remove('.svn')
     if '.git' in dirs:
       dirs.remove('.git')
     for file in files:
       ext = os.path.splitext(file)[1]
-      if ext in extensions:
+      if ext and ext in extensions:
         callback(os.path.join(path, file), actions)
 
 def AddLiteralActions(actions):
   """Add literal actions specified via calls to UserMetrics functions.
 
   Arguments:
     actions: set of actions to add to.
   """
   EXTENSIONS = ('.cc', '.mm', '.c', '.m')
 
@@ skipping 236 matching lines @@
   actions_element = doc.createElement('actions')
   doc.appendChild(actions_element)
 
   # Attach action node based on updated |actions|.
   for action in sorted(actions):
     actions_element.appendChild(
         _CreateActionTag(doc, action, actions_dict.get(action, None)))
 
   return print_style.GetPrintStyle().PrettyPrintNode(doc)
 
-

[Alexei Svitkine (slow), 2014/11/11 20:36:41]

Nit: Revert changes to this file.

[gayane -on leave until 09-2017, 2014/11/12 22:00:23]

I agree I should restore this line, but the other change is useful. Previously
it would consider files without extension as well (e.g. OWNERS, LICENSES)

 def main(argv):
   presubmit = ('--presubmit' in argv)
   actions_xml_path = os.path.join(path_utils.ScriptDir(), 'actions.xml')
 
   # Save the original file content.
   with open(actions_xml_path, 'rb') as f:
     original_xml = f.read()
 
   actions, actions_dict, comment_nodes = ParseActionFile(original_xml)
 
@@ skipping 36 matching lines @@
 
   with open(actions_xml_path, 'wb') as f:
     f.write(pretty)
   print ('Updated %s. Don\'t forget to add it to your changelist' %
          actions_xml_path)
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))