Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 719363002: Remove implicit conversions from scoped_refptr to T* in base/win/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in base/win/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/4a6041e1341aad67fd5675ab9edacc2df4916420 Cr-Commit-Position: refs/heads/master@{#304106}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert silly comparison rewrite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M base/win/scoped_comptr_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
https://codereview.chromium.org/719363002/diff/1/base/win/scoped_comptr.h File base/win/scoped_comptr.h (right): https://codereview.chromium.org/719363002/diff/1/base/win/scoped_comptr.h#newcode137 base/win/scoped_comptr.h:137: static_cast<IUnknown*>(other_identity.get()); I'm reverting this, because once the implicit conversion ...
6 years, 1 month ago (2014-11-12 23:37:54 UTC) #2
dcheng
+rvargas, mind taking a look? This is one of the last automated patches. There's a ...
6 years, 1 month ago (2014-11-13 21:56:14 UTC) #4
rvargas (doing something else)
lgtm
6 years, 1 month ago (2014-11-13 22:19:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719363002/20001
6 years, 1 month ago (2014-11-13 22:22:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 23:07:12 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:36:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a6041e1341aad67fd5675ab9edacc2df4916420
Cr-Commit-Position: refs/heads/master@{#304106}

Powered by Google App Engine
This is Rietveld 408576698