Remove implicit conversions from scoped_refptr to T* in base/win/

base/win/scoped_comptr.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_WIN_SCOPED_COMPTR_H_
 #define BASE_WIN_SCOPED_COMPTR_H_
 
 #include <unknwn.h>
 
 #include "base/logging.h"
@@ skipping 115 matching lines @@
 
     if (!other || !ptr_)
       return false;
 
     ScopedComPtr<IUnknown> my_identity;
     QueryInterface(my_identity.Receive());
 
     ScopedComPtr<IUnknown> other_identity;
     other->QueryInterface(other_identity.Receive());
 
-    return static_cast<IUnknown*>(my_identity) ==
-           static_cast<IUnknown*>(other_identity);
+    return static_cast<IUnknown*>(my_identity.get()) ==
+           static_cast<IUnknown*>(other_identity.get());

[dcheng, 2014/11/12 23:37:54]

I'm reverting this, because once the implicit conversion is disabled, we can
just use scoped_refptr's == directly here.

   }
 
   // Provides direct access to the interface.
   // Here we use a well known trick to make sure we block access to
   // IUnknown methods so that something bad like this doesn't happen:
   //    ScopedComPtr<IUnknown> p(Foo());
   //    p->Release();
   //    ... later the destructor runs, which will Release() again.
   // and to get the benefit of the DCHECKs we add to QueryInterface.
   // There's still a way to call these methods if you absolutely must
@@ skipping 11 matching lines @@
 
   static const IID& iid() {
     return *interface_id;
   }
 };
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_SCOPED_COMPTR_H_