Issue 71933002: Revert 12382 "Deploy new x86 binutils"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71933002: Revert 12382 "Deploy new x86 binutils" (Closed)

Created:
7 years, 1 month ago by nfullagar1

Modified:
7 years, 1 month ago

Reviewers:
Use chromium.org instead, Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/

Visibility:
Public.

More Reviews

Description

Revert 12382 "Deploy new x86 binutils" > Deploy new x86 binutils > > This puts in place the x86 toolchain using the new 2.24-based binutils. > > BUG= https://code.google.com/p/nativeclient/issues/detail?id=3636 > TEST= trybots > R=bsy@google.com, sehr@chromium.org > > Review URL: https://codereview.chromium.org/62643002 TBR=mcgrathr@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12385

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -27 lines)			Patch
M	trunk/src/native_client/SConstruct	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/native_client/TOOL_REVISIONS	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	trunk/src/native_client/build/untrusted.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/native_client/site_scons/site_tools/naclsdk.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/native_client/src/trusted/service_runtime/nacl.scons	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/native_client/src/trusted/validator_ragel/testdata/64/legacy.test	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/native_client/tests/toolchain/nacl.scons	View	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nfullagar1

Committed patchset #1 manually as r12385 (presubmit successful).

7 years, 1 month ago (2013-11-13 19:12:53 UTC) #2

Use chromium.org instead

7 years, 1 month ago (2013-11-13 19:44:00 UTC) #3

Lgtm

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

Expand Messages | Collapse Messages