Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 62643002: Deploy new x86 binutils (Closed)

Created:
7 years, 1 month ago by Roland McGrath
Modified:
7 years, 1 month ago
Reviewers:
bsy, Mark Seaborn, sehr
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Deploy new x86 binutils This puts in place the x86 toolchain using the new 2.24-based binutils. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3636 TEST= trybots R=bsy@google.com, sehr@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12382

Patch Set 1 #

Patch Set 2 : new binutils #

Patch Set 3 : rebased #

Total comments: 2

Patch Set 4 : add TODO comment; disable ncval-using test when using old ncval #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M SConstruct View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M TOOL_REVISIONS View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M build/untrusted.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M site_scons/site_tools/naclsdk.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/nacl.scons View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/validator_ragel/testdata/64/legacy.test View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/toolchain/nacl.scons View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Roland McGrath
7 years, 1 month ago (2013-11-06 18:45:38 UTC) #1
Roland McGrath
PTAL Needs OWNERS LGTM from bsy/mseaborn/khim for validator testdata change.
7 years, 1 month ago (2013-11-12 21:01:36 UTC) #2
sehr
lgtm
7 years, 1 month ago (2013-11-12 21:13:27 UTC) #3
bsy
On 2013/11/12 21:13:27, sehr1 wrote: > lgtm lgtm on validator testdata etc.
7 years, 1 month ago (2013-11-12 21:18:23 UTC) #4
bsy
On 2013/11/12 21:18:23, bsy wrote: > On 2013/11/12 21:13:27, sehr1 wrote: > > lgtm > ...
7 years, 1 month ago (2013-11-12 21:32:53 UTC) #5
Mark Seaborn
https://codereview.chromium.org/62643002/diff/550001/SConstruct File SConstruct (right): https://codereview.chromium.org/62643002/diff/550001/SConstruct#newcode2742 SConstruct:2742: return True Please can you do a follow up ...
7 years, 1 month ago (2013-11-12 21:46:07 UTC) #6
Roland McGrath
On 2013/11/12 21:32:53, bsy wrote: > On 2013/11/12 21:18:23, bsy wrote: > > On 2013/11/12 ...
7 years, 1 month ago (2013-11-12 22:10:30 UTC) #7
Roland McGrath
https://codereview.chromium.org/62643002/diff/550001/SConstruct File SConstruct (right): https://codereview.chromium.org/62643002/diff/550001/SConstruct#newcode2742 SConstruct:2742: return True On 2013/11/12 21:46:07, Mark Seaborn wrote: > ...
7 years, 1 month ago (2013-11-12 22:10:37 UTC) #8
Roland McGrath
Committed patchset #4 manually as r12382 (presubmit successful).
7 years, 1 month ago (2013-11-13 00:02:39 UTC) #9
Mark Seaborn
7 years, 1 month ago (2013-11-15 00:05:23 UTC) #10 
This change seems to be producing some build failures when rolled into
Chromium.

(I know this change has since been reverted.  I mention this so that it can
be debugged for the re-commit.)

FAILED: cd ../../chrome/test/data/nacl; python
../../../../native_client/build/build_nexe.py -t
../../../../out/Release/gen/sdk/toolchain/ --strip-all --arch x86-32
--build glibc_nexe --root ../../../.. --name
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_32.nexe
--objdir
../../../../out/Release/obj/chrome/test/data/nacl/simple_test.gen/glibc-x86-32/simple_test
"--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. "
"--compile_flags=-m32 -fomit-frame-pointer -fasynchronous-unwind-tables
 -O2 -g -Wall -fdiagnostics-show-option -Werror " "--defines=__linux__
\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\"
\"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\"
\"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\"
\"NACL_BUILD_ARCH=x86\" ANGLE_DX11 \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD
\"TOOLKIT_VIEWS=1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\"
\"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_NSS=1\"
\"USE_X11=1\" ENABLE_ONE_CLICK_SIGNIN \"USE_XI2_MT=2\"
\"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" ENABLE_PEPPER_CDMS
ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS
\"DCHECK_ALWAYS_ON=1\" \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\"
\"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\"
\"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\"
\"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\"
\"ENABLE_AUTOMATION=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\"
\"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\"
\"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\"
\"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_MDNS=1\""
"--link_flags=-m32 -B../../../../out/Release/gen/tc_glibc/lib32 -lppapi_cpp
-lppapi -pthread -O3 "
"--source-list=../../../../out/gypfiles/chrome/test/data/nacl/glibc-x86-32.simple_test.source_list.gypcmd"
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `sqrt'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `atan'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `acos'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `exp'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `atan2'
collect2: ld returned 1 exit status
FAILED with 1:
../../../../out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/x86_64-nacl-g++
-o
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_32.nexe.debug
-Wl,--as-needed
../../../../out/Release/obj/chrome/test/data/nacl/simple_test.gen/glibc-x86-32/simple_test/simple.o
-m32 -B../../../../out/Release/gen/tc_glibc/lib32 -lppapi_cpp -lppapi
-pthread -O3
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .interp lma 0x11000000 adjusted to 0x11010000
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .note.gnu.build-id lma 0x1100001c adjusted to 0x1101001b
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .hash lma 0x11000040 adjusted to 0x1101003f
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .dynsym lma 0x11000190 adjusted to 0x1101018b
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .dynstr lma 0x110005b0 adjusted to 0x110105ab
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .gnu.version lma 0x11000992 adjusted to 0x1101098d
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .gnu.version_r lma 0x110009f0 adjusted to 0x110109e5
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .rela.got lma 0x11000ab0 adjusted to 0x11010aa5
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .rela.bss lma 0x11000ac8 adjusted to 0x11010abd
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .rela.plt lma 0x11000b28 adjusted to 0x11010b1d
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .rodata lma 0x11000de0 adjusted to 0x11010dd5
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .eh_frame_hdr lma 0x11000f60 adjusted to 0x11010f55
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .eh_frame lma 0x11000ff8 adjusted to 0x11010fe9
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section .gcc_except_table lma 0x11001234 adjusted to 0x11011225
BFD:
../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe.untagged:
section `.gcc_except_table' can't be allocated in segment 1
LOAD: .interp .note.gnu.build-id .hash .dynsym .dynstr .gnu.version
.gnu.version_r .rela.got .rela.bss .rela.plt .rodata .eh_frame_hdr
.eh_frame .gcc_except_table
BFD: ../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe:
section `.eh_frame' can't be allocated in segment 1
LOAD: .interp .note.gnu.build-id .hash .dynsym .dynstr .gnu.version
.gnu.version_r .rela.got .rela.bss .rela.plt .rodata .eh_frame_hdr .eh_frame
BFD: ../../../../out/Release/nacl_test_data/glibc/simple_glibc_x86_64.nexe:
warning: allocated section `.gcc_except_table' not in segment
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .interp lma 0x11000000 adjusted to 0x11010000
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .note.gnu.build-id lma 0x1100001c adjusted to 0x1101001b
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .hash lma 0x11000040 adjusted to 0x1101003f
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .dynsym lma 0x110001c8 adjusted to 0x110101c7
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .dynstr lma 0x11000750 adjusted to 0x1101074f
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .gnu.version lma 0x11000c16 adjusted to 0x11010c14
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .gnu.version_r lma 0x11000c90 adjusted to 0x11010c8a
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .rela.got lma 0x11000d50 adjusted to 0x11010d4a
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .rela.bss lma 0x11000d68 adjusted to 0x11010d62
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .rela.plt lma 0x11000df8 adjusted to 0x11010df2
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .rodata lma 0x11001200 adjusted to 0x110111e2
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .eh_frame_hdr lma 0x11001460 adjusted to 0x11011442
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .eh_frame lma 0x11001508 adjusted to 0x110114e6
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section .gcc_except_table lma 0x11001794 adjusted to 0x11011772
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe.untagged:
section `.gcc_except_table' can't be allocated in segment 1
LOAD: .interp .note.gnu.build-id .hash .dynsym .dynstr .gnu.version
.gnu.version_r .rela.got .rela.bss .rela.plt .rodata .eh_frame_hdr
.eh_frame .gcc_except_table
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe:
section `.eh_frame' can't be allocated in segment 1
LOAD: .interp .note.gnu.build-id .hash .dynsym .dynstr .gnu.version
.gnu.version_r .rela.got .rela.bss .rela.plt .rodata .eh_frame_hdr .eh_frame
BFD:
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_64.nexe:
warning: allocated section `.gcc_except_table' not in segment
FAILED: cd ../../chrome/test/data/nacl; python
../../../../native_client/build/build_nexe.py -t
../../../../out/Release/gen/sdk/toolchain/ --strip-all --arch x86-32
--build glibc_nexe --root ../../../.. --name
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_32.nexe
--objdir
../../../../out/Release/obj/chrome/test/data/nacl/sysconf_nprocessors_onln_test.gen/glibc-x86-32/sysconf_nprocessors_onln_test
"--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. "
"--compile_flags=-m32 -fomit-frame-pointer -fasynchronous-unwind-tables
 -O2 -g -Wall -fdiagnostics-show-option -Werror " "--defines=__linux__
\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\"
\"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\"
\"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\"
\"NACL_BUILD_ARCH=x86\" ANGLE_DX11 \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD
\"TOOLKIT_VIEWS=1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\"
\"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_NSS=1\"
\"USE_X11=1\" ENABLE_ONE_CLICK_SIGNIN \"USE_XI2_MT=2\"
\"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" ENABLE_PEPPER_CDMS
ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS
\"DCHECK_ALWAYS_ON=1\" \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\"
\"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\"
\"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\"
\"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\"
\"ENABLE_AUTOMATION=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\"
\"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\"
\"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\"
\"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_MDNS=1\""
"--link_flags=-m32 -B../../../../out/Release/gen/tc_glibc/lib32 -lppapi_cpp
-lppapi -pthread -O3 "
"--source-list=../../../../out/gypfiles/chrome/test/data/nacl/glibc-x86-32.sysconf_nprocessors_onln_test.source_list.gypcmd"
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `sqrt'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `atan'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `acos'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `exp'
/mnt/scratch0/b_used/build/slave/linux/build/src/out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/lib/../lib32/libstdc++.so:
undefined reference to `atan2'
collect2: ld returned 1 exit status
FAILED with 1:
../../../../out/Release/gen/sdk/toolchain/linux_x86_glibc/bin/x86_64-nacl-g++
-o
../../../../out/Release/nacl_test_data/glibc/sysconf_nprocessors_onln_test_glibc_x86_32.nexe.debug
-Wl,--as-needed
../../../../out/Release/obj/chrome/test/data/nacl/sysconf_nprocessors_onln_test.gen/glibc-x86-32/sysconf_nprocessors_onln_test/sysconf_nprocessors_onln_test.o
-m32 -B../../../../out/Release/gen/tc_glibc/lib32 -lppapi_cpp -lppapi
-pthread -O3
ninja: build stopped: subcommand failed.

See
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/1892...
(linked from https://codereview.chromium.org/71463004/)

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

Powered by Google App Engine
This is Rietveld 408576698