 Chromium Code Reviews
 Chromium Code Reviews Issue 719243002:
  Move default_locale manifest handler out of //chrome  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 719243002:
  Move default_locale manifest handler out of //chrome  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: extensions/common/manifest_handlers/default_locale_manifest_unittest.cc | 
| diff --git a/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc b/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc | 
| similarity index 75% | 
| rename from chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc | 
| rename to extensions/common/manifest_handlers/default_locale_manifest_unittest.cc | 
| index 351b094c017214a52ea6e1729b057025ff13392d..6e284c673f29c04553ed8f44db5fd95c042d96eb 100644 | 
| --- a/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc | 
| +++ b/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc | 
| @@ -2,15 +2,14 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| -#include "chrome/common/extensions/api/i18n/default_locale_handler.h" | 
| -#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" | 
| #include "extensions/common/manifest_constants.h" | 
| +#include "extensions/common/manifest_handlers/default_locale_handler.h" | 
| +#include "extensions/common/manifest_test.h" | 
| #include "testing/gtest/include/gtest/gtest.h" | 
| namespace extensions { | 
| -class DefaultLocaleManifestTest : public ChromeManifestTest { | 
| -}; | 
| +typedef ManifestTest DefaultLocaleManifestTest; | 
| 
Yoyo Zhou
2014/11/12 21:06:31
You could be an innovator in this:
using DefaultLo
 
Ken Rockot(use gerrit already)
2014/11/12 22:10:55
Oh yeah. Good call. I keep forgetting about this w
 | 
| TEST_F(DefaultLocaleManifestTest, DefaultLocale) { | 
| LoadAndExpectError("default_locale_invalid.json", |