extensions/common/manifest_handlers/default_locale_manifest_unittest.cc - Issue 719243002: Move default_locale manifest handler out of //chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/manifest_handlers/default_locale_manifest_unittest.cc

Issue 719243002: Move default_locale manifest handler out of //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"

6 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

7 #include "extensions/common/manifest_constants.h"	5 #include "extensions/common/manifest_constants.h"

	6 #include "extensions/common/manifest_handlers/default_locale_handler.h"

	7 #include "extensions/common/manifest_test.h"

8 #include "testing/gtest/include/gtest/gtest.h"	8 #include "testing/gtest/include/gtest/gtest.h"

9	9

10 namespace extensions {	10 namespace extensions {

11	11

12 class DefaultLocaleManifestTest : public ChromeManifestTest {	12 typedef ManifestTest DefaultLocaleManifestTest;
	Yoyo Zhou 2014/11/12 21:06:31 You could be an innovator in this: using DefaultLo You could be an innovator in this: using DefaultLocaleManifestTest = ManifestTest; from 'Aliases' on http://chromium-cpp.appspot.com/ Ken Rockot(use gerrit already) 2014/11/12 22:10:55 Oh yeah. Good call. I keep forgetting about this w Show quoted text On 2014/11/12 21:06:31, Yoyo Zhou wrote: > You could be an innovator in this: > using DefaultLocaleManifestTest = ManifestTest; > > from 'Aliases' on http://chromium-cpp.appspot.com/ Oh yeah. Good call. I keep forgetting about this wonderful feature.
13 };

14	13

15 TEST_F(DefaultLocaleManifestTest, DefaultLocale) {	14 TEST_F(DefaultLocaleManifestTest, DefaultLocale) {

16 LoadAndExpectError("default_locale_invalid.json",	15 LoadAndExpectError("default_locale_invalid.json",

17 manifest_errors::kInvalidDefaultLocale);	16 manifest_errors::kInvalidDefaultLocale);

18	17

19 scoped_refptr<Extension> extension(	18 scoped_refptr<Extension> extension(

20 LoadAndExpectSuccess("default_locale_valid.json"));	19 LoadAndExpectSuccess("default_locale_valid.json"));

21 EXPECT_EQ("de-AT", LocaleInfo::GetDefaultLocale(extension.get()));	20 EXPECT_EQ("de-AT", LocaleInfo::GetDefaultLocale(extension.get()));

22 }	21 }

23	22

24 } // namespace extensions	23 } // namespace extensions

OLD	NEW

« no previous file with comments | « extensions/common/manifest_handlers/default_locale_handler.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »