Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719243002: Move default_locale manifest handler out of //chrome (Closed)

Created:
6 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
6 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move default_locale manifest handler out of //chrome BUG=398671 TBR=kalman@chromium.org,jochen@chromium.org for various #include updates Committed: https://crrev.com/e5fd3d99ade77d8b9c3df54d6f4d6e8e7bcd9d6a Cr-Commit-Position: refs/heads/master@{#303934}

Patch Set 1 #

Total comments: 2

Patch Set 2 : type alias #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -223 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/common/extensions/api/i18n/default_locale_handler.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/common/extensions/api/i18n/default_locale_handler.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/default_locale_invalid.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/default_locale_valid.json View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/utility/extensions/unpacker.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/default_locale_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/default_locale_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/default_locale_manifest_unittest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A + extensions/test/data/manifest_tests/default_locale_invalid.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/manifest_tests/default_locale_valid.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Rockot(use gerrit already)
Yoyo, could you please take a look? Almost all of this is header-move noise. I ...
6 years, 1 month ago (2014-11-12 20:26:10 UTC) #2
Yoyo Zhou
LGTM https://codereview.chromium.org/719243002/diff/1/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc File extensions/common/manifest_handlers/default_locale_manifest_unittest.cc (right): https://codereview.chromium.org/719243002/diff/1/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc#newcode12 extensions/common/manifest_handlers/default_locale_manifest_unittest.cc:12: typedef ManifestTest DefaultLocaleManifestTest; You could be an innovator ...
6 years, 1 month ago (2014-11-12 21:06:31 UTC) #3
Ken Rockot(use gerrit already)
https://codereview.chromium.org/719243002/diff/1/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc File extensions/common/manifest_handlers/default_locale_manifest_unittest.cc (right): https://codereview.chromium.org/719243002/diff/1/extensions/common/manifest_handlers/default_locale_manifest_unittest.cc#newcode12 extensions/common/manifest_handlers/default_locale_manifest_unittest.cc:12: typedef ManifestTest DefaultLocaleManifestTest; On 2014/11/12 21:06:31, Yoyo Zhou wrote: ...
6 years, 1 month ago (2014-11-12 22:10:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719243002/20001
6 years, 1 month ago (2014-11-12 23:21:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 00:21:30 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:22:28 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e5fd3d99ade77d8b9c3df54d6f4d6e8e7bcd9d6a
Cr-Commit-Position: refs/heads/master@{#303934}

Powered by Google App Engine
This is Rietveld 408576698