Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718773002: Make mojob.py test succeed on Windows. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
viettrungluu, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make mojob.py test succeed on Windows. Python tests aren't supported because the bindings aren't built on Windows. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f0b4f0f8e2e4f67f4480e68ff34aa4a0d2b07d3

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M mojo/tools/mojob.py View 2 chunks +7 lines, -3 lines 1 comment Download
M mojo/tools/mopy/transitive_hash.py View 1 2 chunks +18 lines, -6 lines 0 comments Download
M mojo/tools/test_runner.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
6 years, 1 month ago (2014-11-11 18:10:35 UTC) #2
viettrungluu
https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py File mojo/tools/mopy/transitive_hash.py (right): https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py#newcode35 mojo/tools/mopy/transitive_hash.py:35: with open(filename, mode='rb') as f: What's the performance of ...
6 years, 1 month ago (2014-11-11 18:35:38 UTC) #3
jam
https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py File mojo/tools/mopy/transitive_hash.py (right): https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py#newcode35 mojo/tools/mopy/transitive_hash.py:35: with open(filename, mode='rb') as f: On 2014/11/11 18:35:38, viettrungluu ...
6 years, 1 month ago (2014-11-11 20:09:32 UTC) #4
viettrungluu
LGTM. On 2014/11/11 20:09:32, jam wrote: > https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py > File mojo/tools/mopy/transitive_hash.py (right): > > https://codereview.chromium.org/718773002/diff/1/mojo/tools/mopy/transitive_hash.py#newcode35 ...
6 years, 1 month ago (2014-11-11 20:39:52 UTC) #5
jam
Committed patchset #2 (id:20001) manually as 0f0b4f0f8e2e4f67f4480e68ff34aa4a0d2b07d3 (presubmit successful).
6 years, 1 month ago (2014-11-11 20:42:43 UTC) #6
qsr
6 years, 1 month ago (2014-11-12 10:27:49 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/718773002/diff/20001/mojo/tools/mojob.py
File mojo/tools/mojob.py (right):

https://codereview.chromium.org/718773002/diff/20001/mojo/tools/mojob.py#newc...
mojo/tools/mojob.py:139: 'aren\'t build there.')
Only the second set of test are unsupported. The first one should be fine.
Should this be move down?

Powered by Google App Engine
This is Rietveld 408576698