Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2072)

Unified Diff: mojo/tools/mojob.py

Issue 718773002: Make mojob.py test succeed on Windows. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/tools/mopy/transitive_hash.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojob.py
diff --git a/mojo/tools/mojob.py b/mojo/tools/mojob.py
index 450069dab5f7aaff16af9c0bc93bb52f50635d22..5a238208cb3088aaeea8ef08426140fb58cf1b10 100755
--- a/mojo/tools/mojob.py
+++ b/mojo/tools/mojob.py
@@ -104,7 +104,7 @@ def build(args):
def run_unittests(args):
out_dir = get_out_dir(args)
print 'Running unit tests in %s ...' % out_dir
- command = []
+ command = ['python']
if platform.system() == 'Linux':
command.append('./testing/xvfb.py')
command.append(out_dir)
@@ -134,15 +134,19 @@ def run_skytests(args):
def run_pytests(args):
+ if platform.system() == 'Windows':
+ print ('pytests aren\'t supported on Windows because the Python bindings '
+ 'aren\'t build there.')
qsr 2014/11/12 10:27:49 Only the second set of test are unsupported. The f
+ return
out_dir = get_out_dir(args)
print 'Running python tests in %s ...' % out_dir
- command = []
+ command = ['python']
command.append(os.path.join('mojo', 'tools', 'run_mojo_python_tests.py'))
exit_code = subprocess.call(command)
if exit_code:
return exit_code
- command = []
+ command = ['python']
command.append(os.path.join('mojo', 'tools',
'run_mojo_python_bindings_tests.py'))
command.append('--build-dir=' + out_dir)
« no previous file with comments | « no previous file | mojo/tools/mopy/transitive_hash.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698