Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718473002: ES6: Add support for super in object literals (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ES6: Add support for super in object literals This only available under --harmony-classes BUG=v8:3571 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25271

Patch Set 1 #

Total comments: 1

Patch Set 2 : Home object should also be added for parenthesized functions #

Patch Set 3 : Conditionally add home object to class methods too #

Patch Set 4 : Add Crankshaft support and expand tests #

Patch Set 5 : Ports too #

Total comments: 8

Patch Set 6 : Fix code review comments #

Total comments: 10

Patch Set 7 : Fix remaining code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -93 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 5 chunks +25 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 5 6 5 chunks +24 lines, -0 lines 0 comments Download
M src/ast.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 2 chunks +13 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 5 chunks +25 lines, -0 lines 0 comments Download
M src/preparser.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 4 chunks +2 lines, -14 lines 0 comments Download
M src/scopes.h View 4 chunks +20 lines, -10 lines 0 comments Download
M src/scopes.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 5 chunks +25 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 5 4 chunks +68 lines, -58 lines 0 comments Download
A test/mjsunit/harmony/object-literals-super.js View 1 2 3 1 chunk +168 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
arv (Not doing code reviews)
PTAL Is this a good approach? Right now it is disabled in Crankshaft and fails ...
6 years, 1 month ago (2014-11-10 18:06:35 UTC) #1
arv (Not doing code reviews)
Home object should also be added for parenthesized functions
6 years, 1 month ago (2014-11-10 18:57:22 UTC) #2
arv (Not doing code reviews)
Conditionally add home object to class methods too
6 years, 1 month ago (2014-11-10 19:04:29 UTC) #3
Dmitry Lomov (no reviews)
All looks good (I haven't reviewed in detail)
6 years, 1 month ago (2014-11-10 19:39:01 UTC) #4
arv (Not doing code reviews)
Add Crankshaft support and expand tests
6 years, 1 month ago (2014-11-10 20:05:28 UTC) #5
arv (Not doing code reviews)
Ports too
6 years, 1 month ago (2014-11-10 21:16:56 UTC) #6
Dmitry Lomov (no reviews)
Nice, only nits. https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc#newcode1387 src/arm/full-codegen-arm.cc:1387: if (expr != NULL && expr->IsFunctionLiteral() ...
6 years, 1 month ago (2014-11-11 11:50:39 UTC) #7
arv (Not doing code reviews)
Fix code review comments
6 years, 1 month ago (2014-11-11 17:18:02 UTC) #8
arv (Not doing code reviews)
PTAL (Sorry, I git rebased this accidentally) https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc#newcode1387 src/arm/full-codegen-arm.cc:1387: if (expr ...
6 years, 1 month ago (2014-11-11 17:19:08 UTC) #9
Dmitry Lomov (no reviews)
lgtm if nits are addressed https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc#newcode1756 src/arm/full-codegen-arm.cc:1756: if (value != NULL ...
6 years, 1 month ago (2014-11-11 19:27:48 UTC) #10
arv (Not doing code reviews)
Fix remaining code review issues
6 years, 1 month ago (2014-11-11 19:48:26 UTC) #11
arv (Not doing code reviews)
https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc#newcode1756 src/arm/full-codegen-arm.cc:1756: if (value != NULL && value->IsFunctionLiteral() && On 2014/11/11 ...
6 years, 1 month ago (2014-11-11 19:51:29 UTC) #12
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-11 19:54:53 UTC) #13
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as 25271 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698