Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: src/hydrogen.cc

Issue 718473002: ES6: Add support for super in object literals (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/full-codegen.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 5601 matching lines...) Expand 10 before | Expand all | Expand 10 after
5612 if (property->IsCompileTimeValue()) continue; 5612 if (property->IsCompileTimeValue()) continue;
5613 5613
5614 Literal* key = property->key(); 5614 Literal* key = property->key();
5615 Expression* value = property->value(); 5615 Expression* value = property->value();
5616 5616
5617 switch (property->kind()) { 5617 switch (property->kind()) {
5618 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 5618 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
5619 DCHECK(!CompileTimeValue::IsCompileTimeValue(value)); 5619 DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
5620 // Fall through. 5620 // Fall through.
5621 case ObjectLiteral::Property::COMPUTED: 5621 case ObjectLiteral::Property::COMPUTED:
5622 // TODO(arv): Add support for [[HomeObject]]
arv (Not doing code reviews) 2014/11/10 18:06:35 This one should not be too hard to fix. I can prob
5623 if (value->IsFunctionLiteral() &&
5624 value->AsFunctionLiteral()->needs_super_binding()) {
5625 return Bailout(kObjectLiteralWithComplexProperty);
5626 }
5627
5622 // It is safe to use [[Put]] here because the boilerplate already 5628 // It is safe to use [[Put]] here because the boilerplate already
5623 // contains computed properties with an uninitialized value. 5629 // contains computed properties with an uninitialized value.
5624 if (key->value()->IsInternalizedString()) { 5630 if (key->value()->IsInternalizedString()) {
5625 if (property->emit_store()) { 5631 if (property->emit_store()) {
5626 CHECK_ALIVE(VisitForValue(value)); 5632 CHECK_ALIVE(VisitForValue(value));
5627 HValue* value = Pop(); 5633 HValue* value = Pop();
5628 Handle<Map> map = property->GetReceiverType(); 5634 Handle<Map> map = property->GetReceiverType();
5629 Handle<String> name = property->key()->AsPropertyName(); 5635 Handle<String> name = property->key()->AsPropertyName();
5630 HInstruction* store; 5636 HInstruction* store;
5631 if (map.is_null()) { 5637 if (map.is_null()) {
(...skipping 7040 matching lines...) Expand 10 before | Expand all | Expand 10 after
12672 if (ShouldProduceTraceOutput()) { 12678 if (ShouldProduceTraceOutput()) {
12673 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 12679 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
12674 } 12680 }
12675 12681
12676 #ifdef DEBUG 12682 #ifdef DEBUG
12677 graph_->Verify(false); // No full verify. 12683 graph_->Verify(false); // No full verify.
12678 #endif 12684 #endif
12679 } 12685 }
12680 12686
12681 } } // namespace v8::internal 12687 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698