pdf/instance.cc - Issue 718453003: Initialize V8 in PDFium from external files (plugin process only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/instance.cc

Issue 718453003: Initialize V8 in PDFium from external files (plugin process only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix API Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/instance.cc

diff --git a/pdf/instance.cc b/pdf/instance.cc

index 2ffc7d47f4edf274b10cbeb00a5475aa9155cd2c..fb8484fdbe748f39930ecdd6255f856dd423a927 100644

--- a/pdf/instance.cc

+++ b/pdf/instance.cc

@@ -322,7 +322,7 @@ Instance::~Instance() {

bool Instance::Init(uint32_t argc, const char* argn[], const char* argv[]) {

v8::StartupData natives;

v8::StartupData snapshot;

- pp::PDF::GetV8ExternalSnapshotData(&natives.data, &natives.raw_size,

+ pp::PDF::GetV8ExternalSnapshotData(this, &natives.data, &natives.raw_size,

&snapshot.data, &snapshot.raw_size);

if (natives.data) {

natives.compressed_size = natives.raw_size;

« no previous file with comments | « components/pdf/renderer/ppb_pdf_impl.cc ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »