components/pdf/renderer/ppb_pdf_impl.cc - Issue 718453003: Initialize V8 in PDFium from external files (plugin process only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf/renderer/ppb_pdf_impl.cc

Issue 718453003: Initialize V8 in PDFium from external files (plugin process only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix API Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/pdf/renderer/ppb_pdf_impl.cc

diff --git a/components/pdf/renderer/ppb_pdf_impl.cc b/components/pdf/renderer/ppb_pdf_impl.cc

index 85be05e154e7cdc024066fc6de90122eb1cae15a..aa0a33a05747ff4484f839353d301293d8aaf6b3 100644

--- a/components/pdf/renderer/ppb_pdf_impl.cc

+++ b/components/pdf/renderer/ppb_pdf_impl.cc

@@ -330,7 +330,8 @@ void SetLinkUnderCursor(PP_Instance instance_id, const char* url) {

instance->SetLinkUnderCursor(url);

}

-void GetV8ExternalSnapshotData(const char** natives_data_out,

+void GetV8ExternalSnapshotData(PP_Instance instance_id,

+ const char** natives_data_out,

int* natives_size_out,

const char** snapshot_data_out,

int* snapshot_size_out) {

« no previous file with comments | « chrome/plugin/chrome_content_plugin_client.cc ('k') | pdf/instance.cc » ('j') | no next file with comments »