Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 718443002: Change where layer hoisting data is gathered (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Change where layer hoisting data is gathered This CL: 1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice 2) moves the saveLayer gathering step to endRecording 3) Replaces GPUOptimize with SkRecordComputeLayers 4) Update bench_pictures & render_pictures to provide the new flag #2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording) Committed: https://skia.googlesource.com/skia/+/81f71b6630a9b7398bf983689436cccdd8dd3ff7

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Fix merge problem #

Patch Set 4 : Fix multipicturedraw GM #

Patch Set 5 : Add early out #

Patch Set 6 : Fix no-GPU build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -105 lines) Patch
M gm/multipicturedraw.cpp View 1 2 3 6 chunks +23 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +0 lines, -8 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/SkPictureRecorder.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 2 3 4 5 3 chunks +42 lines, -1 line 0 comments Download
M src/gpu/GrPictureUtils.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 4 chunks +12 lines, -23 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 2 chunks +7 lines, -19 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 3 4 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
lgtm
6 years, 1 month ago (2014-11-10 18:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718443002/80001
6 years, 1 month ago (2014-11-10 21:54:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/547) Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/759)
6 years, 1 month ago (2014-11-10 21:56:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718443002/100001
6 years, 1 month ago (2014-11-11 12:45:51 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 12:54:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/81f71b6630a9b7398bf983689436cccdd8dd3ff7

Powered by Google App Engine
This is Rietveld 408576698