net/udp/udp_socket_win.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_win.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_socket_win.cc

diff --git a/net/udp/udp_socket_win.cc b/net/udp/udp_socket_win.cc

index b18aa0a53693403d727acee938022bb7b7012239..5d134f8616a8eb58afc80eda9dec74d9d5347418 100644

--- a/net/udp/udp_socket_win.cc

+++ b/net/udp/udp_socket_win.cc

@@ -805,8 +805,8 @@ int UDPSocketWin::RandomBind(const IPAddressNumber& address) {

DCHECK(bind_type_ == DatagramSocket::RANDOM_BIND && !rand_int_cb_.is_null());

for (int i = 0; i < kBindRetries; ++i) {

- int rv = DoBind(IPEndPoint(address,

- rand_int_cb_.Run(kPortStart, kPortEnd)));

+ int rv = DoBind(IPEndPoint(

+ address, static_cast<uint16>(rand_int_cb_.Run(kPortStart, kPortEnd))));

if (rv == OK || rv != ERR_ADDRESS_IN_USE)

return rv;

}