net/test/embedded_test_server/embedded_test_server.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/embedded_test_server/embedded_test_server.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/embedded_test_server/embedded_test_server.cc

diff --git a/net/test/embedded_test_server/embedded_test_server.cc b/net/test/embedded_test_server/embedded_test_server.cc

index 7ac764fb7087a273157a769eca487c010b1fad50..baf517ce9c7643940d50269eab8f76177ee29a62 100644

--- a/net/test/embedded_test_server/embedded_test_server.cc

+++ b/net/test/embedded_test_server/embedded_test_server.cc

@@ -115,7 +115,7 @@ void HttpListenSocket::DetachFromThread() {

}

EmbeddedTestServer::EmbeddedTestServer()

- : port_(-1),

+ : port_(65535),

mmenke 2014/11/13 16:00:42 0 is probably a better initial value - 65535 is a

Peter Kasting 2014/11/14 20:42:53 Done.

weak_factory_(this) {

DCHECK(thread_checker_.CalledOnValidThread());

}