Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 718253002: Remove implicit conversions from scoped_refptr to T* in chrome/installer (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/installer This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/fb77f1ec663905428e3e9757e5ea91b220561aae Cr-Commit-Position: refs/heads/master@{#303930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M chrome/installer/util/advanced_firewall_manager_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/legacy_firewall_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/wmi.cc View 4 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 1 month ago (2014-11-12 22:50:09 UTC) #2
robertshield
lgtm
6 years, 1 month ago (2014-11-12 23:08:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718253002/1
6 years, 1 month ago (2014-11-12 23:12:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 00:08:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:09:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb77f1ec663905428e3e9757e5ea91b220561aae
Cr-Commit-Position: refs/heads/master@{#303930}

Powered by Google App Engine
This is Rietveld 408576698