Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5876)

Unified Diff: chrome/installer/util/advanced_firewall_manager_win.cc

Issue 718253002: Remove implicit conversions from scoped_refptr to T* in chrome/installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/legacy_firewall_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/advanced_firewall_manager_win.cc
diff --git a/chrome/installer/util/advanced_firewall_manager_win.cc b/chrome/installer/util/advanced_firewall_manager_win.cc
index 80d78c11222a196e20174cb2116f09d41e08f9c1..eca0da5ac3b672ed1a26e1978cd0e4d5bfa53286 100644
--- a/chrome/installer/util/advanced_firewall_manager_win.cc
+++ b/chrome/installer/util/advanced_firewall_manager_win.cc
@@ -80,7 +80,7 @@ bool AdvancedFirewallManager::AddUDPRule(const base::string16& rule_name,
if (!udp_rule.get())
return false;
- HRESULT hr = firewall_rules_->Add(udp_rule);
+ HRESULT hr = firewall_rules_->Add(udp_rule.get());
DLOG_IF(ERROR, FAILED(hr)) << logging::SystemErrorCodeToString(hr);
return SUCCEEDED(hr);
}
@@ -155,7 +155,7 @@ void AdvancedFirewallManager::GetAllRules(
}
base::win::ScopedComPtr<IEnumVARIANT> rules_enum;
- hr = rules_enum.QueryFrom(rules_enum_unknown);
+ hr = rules_enum.QueryFrom(rules_enum_unknown.get());
if (FAILED(hr)) {
DLOG(ERROR) << logging::SystemErrorCodeToString(hr);
return;
« no previous file with comments | « no previous file | chrome/installer/util/legacy_firewall_manager_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698