Issue 718223002: merge {#303347} Plugin service: Use the correct registry key for each watch operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718223002: merge {#303347} Plugin service: Use the correct registry key for each watch operation. (Closed)

Created:
6 years, 1 month ago by rvargas (doing something else)

Modified:
6 years, 1 month ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

merge {#303347} Plugin service: Use the correct registry key for each watch operation. 6f315b85b9126cdbbeee5 master@{#300036} introduced a regression where the two registry keys that are watched for changes to detect installation of NPAPI plugins, were being mixed. This CL fixes the issue... using the correct key each time a new StartWatching is called. BUG=428560 R=piman@chromium.org Review URL: https://codereview.chromium.org/708933002 Cr-Commit-Position: refs/heads/master@{#303347} (cherry picked from commit b805615793e5ddcf7aae67f90672027d76857f29) TBR=piman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5c4fc4699c67b4cfc8c760d5c6d78a06ab70d33c

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/plugin_service_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

rvargas (doing something else)

6 years, 1 month ago (2014-11-12 21:38:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5c4fc4699c67b4cfc8c760d5c6d78a06ab70d33c (presubmit successful).