Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 708933002: Plugin service: Use the correct registry key for each watch operation. (Closed)

Created:
6 years, 1 month ago by rvargas (doing something else)
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Plugin service: Use the correct registry key for each watch operation. 6f315b85b9126cdbbeee5 master@{#300036} introduced a regression where the two registry keys that are watched for changes to detect installation of NPAPI plugins, were being mixed. This CL fixes the issue... using the correct key each time a new StartWatching is called. BUG=428560 R=piman@chromium.org Committed: https://crrev.com/b805615793e5ddcf7aae67f90672027d76857f29 Cr-Commit-Position: refs/heads/master@{#303347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/plugin_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rvargas (doing something else)
6 years, 1 month ago (2014-11-07 02:11:36 UTC) #1
rvargas (doing something else)
PTAL
6 years, 1 month ago (2014-11-07 23:41:59 UTC) #3
piman
lgtm
6 years, 1 month ago (2014-11-07 23:56:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708933002/1
6 years, 1 month ago (2014-11-08 00:39:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 01:44:35 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 01:45:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b805615793e5ddcf7aae67f90672027d76857f29
Cr-Commit-Position: refs/heads/master@{#303347}

Powered by Google App Engine
This is Rietveld 408576698