Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718203005: Implement declarative content script API for <webview> [js part]. (Closed)

Created:
6 years, 1 month ago by Xi Han
Modified:
6 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement declarative content script API for <webview> [js part]. Sample code: var webview = document.querySelector('webview'); var rule = { conditions: [ new chrome.declarativeContent.PageStateMatcher( { pageUrl: { hostContains: '' } })], actions: [ new chrome.declarativeContent.RequestContentScript( {js: ['script.js']}) ] }; webview.request.onPageChanged.addRules([rule]); BUG=437566 Committed: https://crrev.com/6ca136250497327f235096a60babd6394e825d32 Cr-Commit-Position: refs/heads/master@{#309030}

Patch Set 1 #

Patch Set 2 : Handle the "declarativeContent" event naming. #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Patch Set 5 : Move to experimantal. #

Total comments: 2

Patch Set 6 : Introduce DeclarativeContentEvent. #

Total comments: 4

Patch Set 7 : Updated based on another refactor "Issue 794803002: Refactor: cleanup declarative_api.cc.". #

Patch Set 8 : Updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_web_view_experimental.js View 1 2 3 4 5 6 7 2 chunks +49 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 3 4 5 2 chunks +33 lines, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_events.js View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Xi Han
6 years, 1 month ago (2014-11-18 15:07:00 UTC) #3
Xi Han
PTAL, thanks!
6 years ago (2014-12-09 22:02:54 UTC) #4
Fady Samuel
https://codereview.chromium.org/718203005/diff/100001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js File chrome/renderer/resources/extensions/chrome_web_view_experimental.js (right): https://codereview.chromium.org/718203005/diff/100001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js#newcode188 chrome/renderer/resources/extensions/chrome_web_view_experimental.js:188: new WebRequestEvent( Use EventBindings.Event instead: https://code.google.com/p/chromium/codesearch#chromium/src/extensions/renderer/resources/guest_view/web_view_events.js&q=web_view_events.js&sq=package:chromium&type=cs&l=17
6 years ago (2014-12-09 22:09:47 UTC) #5
Xi Han
Fady: PTAL, thanks:) https://codereview.chromium.org/718203005/diff/100001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js File chrome/renderer/resources/extensions/chrome_web_view_experimental.js (right): https://codereview.chromium.org/718203005/diff/100001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js#newcode188 chrome/renderer/resources/extensions/chrome_web_view_experimental.js:188: new WebRequestEvent( On 2014/12/09 22:09:47, Fady ...
6 years ago (2014-12-10 14:57:13 UTC) #8
Fady Samuel
lgtm
6 years ago (2014-12-10 15:42:43 UTC) #9
Fady Samuel
sorry, missed declarative_api.cc changes. not lgtm.
6 years ago (2014-12-10 15:45:05 UTC) #10
Fady Samuel
https://codereview.chromium.org/718203005/diff/160001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js File chrome/renderer/resources/extensions/chrome_web_view_experimental.js (right): https://codereview.chromium.org/718203005/diff/160001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js#newcode203 chrome/renderer/resources/extensions/chrome_web_view_experimental.js:203: 'webViewInternal.declarativeContent.' + Can we try calling this by its ...
6 years ago (2014-12-10 15:56:47 UTC) #11
Xi Han
PTAL, thanks! https://codereview.chromium.org/718203005/diff/160001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js File chrome/renderer/resources/extensions/chrome_web_view_experimental.js (right): https://codereview.chromium.org/718203005/diff/160001/chrome/renderer/resources/extensions/chrome_web_view_experimental.js#newcode203 chrome/renderer/resources/extensions/chrome_web_view_experimental.js:203: 'webViewInternal.declarativeContent.' + On 2014/12/10 15:56:47, Fady Samuel ...
6 years ago (2014-12-11 16:40:04 UTC) #14
Fady Samuel
lgtm
6 years ago (2014-12-12 20:19:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718203005/240001
6 years ago (2014-12-18 16:38:14 UTC) #17
commit-bot: I haz the power
Committed patchset #8 (id:240001)
6 years ago (2014-12-18 17:46:41 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-18 18:05:55 UTC) #19
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/6ca136250497327f235096a60babd6394e825d32
Cr-Commit-Position: refs/heads/master@{#309030}

Powered by Google App Engine
This is Rietveld 408576698