Implement declarative content script API for <webview> [js part].

extensions/browser/api/declarative/declarative_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative/declarative_api.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/task_runner_util.h"
@@ skipping 16 matching lines @@
 namespace AddRules = extensions::core_api::events::Event::AddRules;
 namespace GetRules = extensions::core_api::events::Event::GetRules;
 namespace RemoveRules = extensions::core_api::events::Event::RemoveRules;
 
 
 namespace extensions {
 
 namespace {
 
 const char kWebRequest[] = "declarativeWebRequest.";
+const char kDeclarativeContent[] = "declarativeContent.";
 const char kWebViewExpectedError[] = "Webview event with Webview ID expected.";
 
 bool IsWebViewEvent(const std::string& event_name) {
   // Sample event names:
   // webViewInternal.onRequest.
   // webViewInternal.onMessage.
   return event_name.compare(0,
                             strlen(webview::kWebViewEventPrefix),
                             webview::kWebViewEventPrefix) == 0;
 }
 
 std::string GetWebRequestEventName(const std::string& event_name) {
   std::string web_request_event_name(event_name);
   if (IsWebViewEvent(web_request_event_name)) {
-    web_request_event_name.replace(
-        0, strlen(webview::kWebViewEventPrefix), kWebRequest);
+    if (web_request_event_name.find(kDeclarativeContent) == std::string::npos) {
+      web_request_event_name.replace(
+          0, strlen(webview::kWebViewEventPrefix), kWebRequest);
+    } else {
+      web_request_event_name.replace(
+          0, strlen(webview::kWebViewEventPrefix), "");
+    }
   }
   return web_request_event_name;
 }
 
 void ConvertBinaryDictionaryValuesToBase64(base::DictionaryValue* dict);
 
 // Encodes |binary| as base64 and returns a new StringValue populated with the
 // encoded string.
 scoped_ptr<base::StringValue> ConvertBinaryToBase64(base::BinaryValue* binary) {
   std::string binary_data = std::string(binary->GetBuffer(), binary->GetSize());
@@ skipping 76 matching lines @@
   std::string event_name;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &event_name));
 
   int web_view_instance_id = 0;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(1, &web_view_instance_id));
   int embedder_process_id = render_view_host()->GetProcess()->GetID();
 
   bool has_web_view = web_view_instance_id != 0;
   if (has_web_view != IsWebViewEvent(event_name))
     EXTENSION_FUNCTION_ERROR(kWebViewExpectedError);
   event_name = GetWebRequestEventName(event_name);

[Fady Samuel, 2014/12/10 15:56:47]

Are the three lines above necessary? Can we clean this up? Can we get rid of
GetWebRequestEventName all together?

[Xi Han, 2014/12/11 16:40:04]

Done.

 
   // If we are not operating on a particular <webview>, then the key is 0.
   int rules_registry_id = RulesRegistryService::kDefaultRulesRegistryID;
   if (has_web_view) {
     rules_registry_id = WebViewGuest::GetOrGenerateRulesRegistryID(
         embedder_process_id, web_view_instance_id, browser_context());
   }
 
   // The following call will return a NULL pointer for apps_shell, but should
   // never be called there anyways.
@@ skipping 59 matching lines @@
   } else {
     rules_registry_->GetAllRules(extension_id(), &rules);
   }
 
   results_ = GetRules::Results::Create(rules);
 
   return true;
 }
 
 }  // namespace extensions