Issue 718173002: Merging in cl to help debug major crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718173002: Merging in cl to help debug major crash. (Closed)

Created:
6 years, 1 month ago by matthewyuan

Modified:
6 years, 1 month ago

Reviewers:
cpu_(ooo_6.6-7.5), ananta

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

Merging in cl to help debug major crash. Add debug::Alias for version to track unexpected DwmIsCompositionEnabled call DwmIsCompositionEnabled is being called on XP machines, which doesn't make any sense given the version check. Alias version to see what's actually being returned for these crashes. Will need to be merged to 40. R=ananta@chromium.org TBR=cpu@chromium.org BUG=431549 Review URL: https://codereview.chromium.org/711053004 Cr-Commit-Position: refs/heads/master@{#303527} (cherry picked from commit c40bdae7b12c5228bd6fdae53250704a75326988) Committed: https://chromium.googlesource.com/chromium/src/+/8053a08b2a7fc0404f2550a9924b5b06b5230cbf

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ui/base/win/shell.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

matthewyuan

6 years, 1 month ago (2014-11-12 20:05:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8053a08b2a7fc0404f2550a9924b5b06b5230cbf.