Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 711053004: Add debug::Alias for version to track unexpected DwmIsCompositionEnabled call (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
CC:
chromium-reviews, ananta, matthewyuan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add debug::Alias for version to track unexpected DwmIsCompositionEnabled call DwmIsCompositionEnabled is being called on XP machines, which doesn't make any sense given the version check. Alias version to see what's actually being returned for these crashes. Will need to be merged to 40. R=ananta@chromium.org TBR=cpu@chromium.org BUG=431549 Committed: https://chromium.googlesource.com/chromium/src/+/c40bdae7b12c5228bd6fdae53250704a75326988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/base/win/shell.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
6 years, 1 month ago (2014-11-10 21:58:37 UTC) #1
ananta
lgtm
6 years, 1 month ago (2014-11-10 22:51:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c40bdae7b12c5228bd6fdae53250704a75326988 Cr-Commit-Position: refs/heads/master@{#303527}
6 years, 1 month ago (2014-11-10 22:54:59 UTC) #4
scottmg
6 years, 1 month ago (2014-11-10 22:55:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c40bdae7b12c5228bd6fdae53250704a75326988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698