Add chrome sync tests to the GN build.

Add chrome sync tests to the GN build.

This adds sync_integration_tests, sync_performance_tests, and the sync test support targets.

I removed some files that were duplicated between the sync integration tests and the test support. In GYP the fact that test support was a static library hid the duplicate symbols.

Add a dependency on sessions_core from sessions test support since it's required to link. Made test support target be a source set (linking source sets into static libraries will often duplicate symbols).

Committed: https://crrev.com/d60468061789084ebd98458b9743726cc1541786
Cr-Commit-Position: refs/heads/master@{#304904}

[brettw, 2014-11-19 20:05:36]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-11-19 20:15:47]

lgtm

https://codereview.chromium.org/717923006/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/717923006/diff/1/chrome/test/BUILD.gn#newcode292
chrome/test/BUILD.gn:292:
"../browser/sync/test/integration/multiple_client_dictionary_sync_test.cc",
the ../ is kind of weird, do you think it's better in the subdir like this?

https://codereview.chromium.org/717923006/diff/1/chrome/test/BUILD.gn#newcode382
chrome/test/BUILD.gn:382: # TODO(GYP)
just delete this

[scottmg, 2014-11-19 20:16:14]

fyi, can also do 

git cl try -b win8_chromium_gn_dbg -b win8_chromium_gn_rel

now.

[brettw, 2014-11-19 20:22:36]

https://codereview.chromium.org/717923006/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/717923006/diff/1/chrome/test/BUILD.gn#newcode292
chrome/test/BUILD.gn:292:
"../browser/sync/test/integration/multiple_client_dictionary_sync_test.cc",
On 2014/11/19 20:15:47, scottmg wrote:
> the ../ is kind of weird, do you think it's better in the subdir like this?

I think there is value in keeping the toplevel Chrome BUILD file smaller. It's
already >600 lines with no file lists and no test targets.

It's not that weird to have "../" here because all the other ones e.g. in
browser/BUILD.gn have to do the same thing.

I think if I was designing this from scratch, the subdirectories like
chrome/browser would each define source tests of targets related to them that
would get linked into various larger test targets in chrome/test.

[brettw, 2014-11-19 21:35:01]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-19 21:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/717923006/40001

[commit-bot: I haz the power, 2014-11-19 22:23:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-19 22:23:39]

Patchset 3 (id:??) landed as
https://crrev.com/d60468061789084ebd98458b9743726cc1541786
Cr-Commit-Position: refs/heads/master@{#304904}

[Pete Williamson, 2014-11-20 19:13:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/746563002/ by petewil@chromium.org.

The reason for reverting is: This seems the most likely culprit behind
sync_integration_test build and test errors that started in the patch that
included this change..