Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 717873005: Make DOMArrayBuffer()::byteLength() return unsigned int to match the type of its backing data. (Closed)

Created:
6 years, 1 month ago by xun.sun
Modified:
6 years, 1 month ago
Reviewers:
haraken, eroman, Yuki
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make DOMArrayBuffer()::byteLength() return unsigned int to match the type of its backing data. R=yukishiino@chromium.org TBR=haraken@chromium.org TESTS=build on Linux BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/dom/DOMArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
eroman
L.G.T.M (will leave final approval to yukishiino-san)
6 years, 1 month ago (2014-11-12 02:54:23 UTC) #2
Yuki
lgtm
6 years, 1 month ago (2014-11-12 04:16:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717873005/1
6 years, 1 month ago (2014-11-12 04:17:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19540)
6 years, 1 month ago (2014-11-12 04:20:06 UTC) #7
Yuki
haraken, could you review this CL? It was my mistake that I made type of ...
6 years, 1 month ago (2014-11-12 06:09:21 UTC) #9
haraken
LGTM
6 years, 1 month ago (2014-11-12 07:06:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717873005/1
6 years, 1 month ago (2014-11-12 07:45:31 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 07:48:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185188

Powered by Google App Engine
This is Rietveld 408576698